Add IterableOnce operations to IterableOnceOps #8330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scala/bug#11675 This change is backward compatible, because nothing is removed. It should also be forward compatible, because `IterableOnceOps[A]` had `IterableOnce[A]` as a self-type on 2.13.0, meaning that code relying on the newly introduced methods also worked on 2.13.0 because any `IterableOnceOps[A]` instance was also effectively an `IterableOnce[A]`.
Not sure that this is enough for foward compatibility. If with this change you can get the compiler to emit something like: invokeinterface scala/collection/IterableOnceOps.iterable:()Lscala/collection/Iterable;Then if this classfile is run with the 2.13.0 library jar, you'll probably get a runtime exception since there's no |
diesalbla
added
the
library:collections
|
I’m closing the PR because it breaks binary compatibility, as explained by @smarter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#11675
This change is backward compatible, because nothing is removed.
It should also be forward compatible, because
IterableOnceOps[A]hadIterableOnce[A]as a self-type on 2.13.0, meaning that code relying on thenewly introduced methods also worked on 2.13.0 because any
IterableOnceOps[A]instance was also effectively an
IterableOnce[A].