Merge pull request #100 from NthPortal/future-onsuccess

retronym · web-flow · commit 668c31a36a3a · 2018-03-05T12:24:48.000+10:00
Remove override of `Future.onSuccess`
diff --git a/src/main/scala/scala/concurrent/java8/FutureConvertersImpl.scala b/src/main/scala/scala/concurrent/java8/FutureConvertersImpl.scala
@@ -87,8 +87,6 @@ object FuturesConvertersImpl {
   }
 
   class P[T](val wrapped: CompletionStage[T]) extends DefaultPromise[T] with BiConsumer[T, Throwable] {
-    override def onSuccess[U](pf: PartialFunction[T, U])(implicit executor: ExecutionContext): Unit = super.onSuccess(pf)
-
     override def accept(v: T, e: Throwable): Unit = {
       if (e == null) complete(Success(v))
       else complete(Failure(e))

Original file line number	Diff line number	Diff line change
`@@ -87,8 +87,6 @@ object FuturesConvertersImpl {`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`class P[T](val wrapped: CompletionStage[T]) extends DefaultPromise[T] with BiConsumer[T, Throwable] {`
`90`		`- override def onSuccess[U](pf: PartialFunction[T, U])(implicit executor: ExecutionContext): Unit = super.onSuccess(pf)`
`91`		`-`
`92`	`90`	`override def accept(v: T, e: Throwable): Unit = {`
`93`	`91`	`if (e == null) complete(Success(v))`
`94`	`92`	`else complete(Failure(e))`