Skip to content
This repository was archived by the owner on Feb 23, 2018. It is now read-only.

Commit aceecb4

Browse files
committed
Update README.md after upgrading to ASM 5.0.4
1 parent 4884ef6 commit aceecb4

File tree

1 file changed

+18
-19
lines changed

1 file changed

+18
-19
lines changed

README.md

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,16 @@ This makes it easy to see how our fork differs from the official release.
2222
The current sources are based on the following version of ASM ([browse tags here](http://websvn.ow2.org/listing.php?repname=asm&path=%2Ftags%2F&peg=1748)):
2323

2424
```
25-
Version 5.0.3, SVN r1748, tags/ASM_5_0_3
25+
Version 5.0.4, SVN r1779, tags/ASM_5_0_4
2626
```
2727

28+
Previous ASM Upgrade PR: https://github.com/scala/scala-asm/pull/5
29+
2830
## Upgrading ASM
2931

3032
Start by deleting all source files and copy the ones from the latest ASM release.
3133

32-
The original ASM sources are in an SVN repository, which is mirrored here: https://github.com/lrytz/asm.
34+
The original ASM sources are in an [SVN repository](http://forge.ow2.org/plugins/scmsvn/index.php?group_id=23), which is mirrored here: https://github.com/lrytz/asm.
3335
You can use this mirror, your own git-svn mirror, or the original SVN repository to grab the sources of a new ASM version.
3436
A description how to work with the git-svn clone is here: https://github.com/lrytz/asm/issues/1.
3537

@@ -39,27 +41,24 @@ Excluded Files (don't copy):
3941
* `org/objectweb/asm/optimizer`
4042
* `org/objectweb/asm/xml`
4143

42-
*The below will change once a first is done in the new `scala/scala-asm` repository.*
43-
*In the new repository, it probably makes sense to only squash the "Re-packaging and cosmetic changes".*
44-
*The "actual changes" can then stay in the commit history.*
45-
46-
Check the commit history of `src/asm`: https://github.com/scala/scala/commits/2.11.x/src/asm.
47-
Find the previous commit that upgraded ASM and take a look at its commit message.
48-
It should be a squashed version of a pull request that shows the precise procedure how the last upgrade was made.
44+
Take a look at the previous PR that upgraded ASM [(see above)](#current-version).
45+
Follow the upgrade procedure in the same way.
4946

50-
Re-packaging and cosmetic changes:
47+
The re-packaging and cleanup commits can be applied using the following commands:
5148
* convert line endings (there are some `CRLF`)
52-
`find src/asm/scala/tools/asm -name '*.java' | xargs dos2unix`
49+
`find src -name '*.java' | xargs dos2unix`
5350
* change package clauses
54-
`find src/asm/scala/tools/asm -name '*.java' | xargs sed -i '' -e 's/package org\.objectweb\.asm/package scala.tools.asm/'`
51+
`find src -name '*.java' | xargs sed -i '' -e 's/package org\.objectweb\.asm/package scala.tools.asm/'`
5552
* update imports
56-
`find src/asm/scala/tools/asm -name '*.java' | xargs sed -i '' -e 's/import org\.objectweb\.asm/import scala.tools.asm/'`
53+
`find src -name '*.java' | xargs sed -i '' -e 's/import org\.objectweb\.asm/import scala.tools.asm/'`
5754
* update `@links`, `@associates`
58-
`find src/asm/scala/tools/asm -name '*.java' | xargs sed -i '' -e 's/@link org\.objectweb\.asm/@link scala.tools.asm/'`
59-
`find src/asm/scala/tools/asm -name '*.java' | xargs sed -i '' -e 's/@associates org\.objectweb\.asm/@associates scala.tools.asm/'`
55+
`find src -name '*.java' | xargs sed -i '' -e 's/@link org\.objectweb\.asm/@link scala.tools.asm/'`
56+
`find src -name '*.java' | xargs sed -i '' -e 's/@associates org\.objectweb\.asm/@associates scala.tools.asm/'`
6057
* remove trailing whitespace
61-
`find src/asm/scala/tools/asm -name '*.java' | xargs sed -i '' -e 's/[ ]*$//'`
58+
`find src -name '*.java' | xargs sed -i '' -e 's/[ ]*$//'`
59+
60+
Cherry-pick the actual changes that we have in our fork:
61+
* Include the commits labelled `[asm-cherry-pick]` in the previous upgrade PR
62+
* Include the changes to `src` that were added since the last upgrade, and label them `[asm-cherry-pick]`
6263

63-
Include the actual changes that we have in our repostiory
64-
* Include the commits labelled `[asm-cherry-pick]` in the non-squashed PR of the previous upgrade
65-
* Include the changes that were added to src/asm since the last upgrade and label them `[asm-cherry-pick]`
64+
Update the ["Current Version"](#current-version) section of this README.

0 commit comments

Comments
 (0)