From b7929a3107faa541624899e14aa7754f594b5437 Mon Sep 17 00:00:00 2001 From: boggye <2925505+boggye@users.noreply.github.com> Date: Mon, 10 Oct 2022 20:02:28 -0700 Subject: [PATCH 1/3] Update macros.md I wanted to make it clear that in the `inspect` example presented, the println call gets executed at compile time. --- _overviews/scala3-macros/tutorial/macros.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_overviews/scala3-macros/tutorial/macros.md b/_overviews/scala3-macros/tutorial/macros.md index 5074da58bc..9a2395d235 100644 --- a/_overviews/scala3-macros/tutorial/macros.md +++ b/_overviews/scala3-macros/tutorial/macros.md @@ -20,7 +20,7 @@ A Scala expression with type `T` is represented by an instance of the type `scal We will dig into the details of the type `Expr[T]`, as well as the different ways of analyzing and constructing instances, when talking about [Quoted Code][quotes] and [Reflection][tasty]. For now, it suffices to know that macros are metaprograms that manipulate expressions of type `Expr[T]`. -The following macro implementation prints the expression of the provided argument: +The following macro implementation prints the expression of the provided argument at compile time: ```scala import scala.quoted.* // imports Quotes, Expr From 5b343d6148600d69125a949e7f7e5fa709b46638 Mon Sep 17 00:00:00 2001 From: boggye <2925505+boggye@users.noreply.github.com> Date: Tue, 11 Oct 2022 10:57:44 -0700 Subject: [PATCH 2/3] Update _overviews/scala3-macros/tutorial/macros.md Yes, I've noticed that as well. Even on this page sometimes "compile time" is used, in other places "compile-time". It's not used consistently. I am not sure which version is the correct one. It's one of those things. Co-authored-by: Julien Richard-Foy --- _overviews/scala3-macros/tutorial/macros.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_overviews/scala3-macros/tutorial/macros.md b/_overviews/scala3-macros/tutorial/macros.md index 9a2395d235..e7edc3f010 100644 --- a/_overviews/scala3-macros/tutorial/macros.md +++ b/_overviews/scala3-macros/tutorial/macros.md @@ -20,7 +20,7 @@ A Scala expression with type `T` is represented by an instance of the type `scal We will dig into the details of the type `Expr[T]`, as well as the different ways of analyzing and constructing instances, when talking about [Quoted Code][quotes] and [Reflection][tasty]. For now, it suffices to know that macros are metaprograms that manipulate expressions of type `Expr[T]`. -The following macro implementation prints the expression of the provided argument at compile time: +The following macro implementation prints the expression of the provided argument at compile-time: ```scala import scala.quoted.* // imports Quotes, Expr From 55298c5d8e2af7ce80e80ec89c997c9ae81a9ba7 Mon Sep 17 00:00:00 2001 From: boggye <2925505+boggye@users.noreply.github.com> Date: Tue, 11 Oct 2022 13:19:18 -0700 Subject: [PATCH 3/3] Update macros.md Added "in the standard output of the compiler process" as per Julien's suggestion to make it even clearer where the output from the println statement goes. --- _overviews/scala3-macros/tutorial/macros.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_overviews/scala3-macros/tutorial/macros.md b/_overviews/scala3-macros/tutorial/macros.md index e7edc3f010..77ba07d45b 100644 --- a/_overviews/scala3-macros/tutorial/macros.md +++ b/_overviews/scala3-macros/tutorial/macros.md @@ -20,7 +20,7 @@ A Scala expression with type `T` is represented by an instance of the type `scal We will dig into the details of the type `Expr[T]`, as well as the different ways of analyzing and constructing instances, when talking about [Quoted Code][quotes] and [Reflection][tasty]. For now, it suffices to know that macros are metaprograms that manipulate expressions of type `Expr[T]`. -The following macro implementation prints the expression of the provided argument at compile-time: +The following macro implementation prints the expression of the provided argument at compile-time in the standard output of the compiler process: ```scala import scala.quoted.* // imports Quotes, Expr