Skip to content

Commit ef8f171

Browse files
committed
modernise the content somewhat
1 parent c692ad3 commit ef8f171

File tree

8 files changed

+137
-140
lines changed

8 files changed

+137
-140
lines changed

_contribute_resources/3-code-reviews.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@ link: /overviews/contribute/codereviews.html
44
icon: fa fa-eye
55
---
66
Review pull requests against [scala/scala](https://github.com/scala/scala/pulls),
7+
[lampepfl/dotty](https://github.com/lampepfl/dotty/pulls),
78
[scala/scala-lang](https://github.com/scala/scala-lang/pulls),
89
[scala/docs.scala-lang](https://github.com/scala/docs.scala-lang/pulls) and others.

_overviews/contribute/bug-reporting-guide.md

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ partof: scala-contribution
66
overview-name: Contributing to Scala
77
---
88

9-
The Scala compiler and standard library bug tracker is located at [https://github.com/scala/bug](https://github.com/scala/bug). Before you submit a bug make sure that it is certainly a bug by following instructions in *Is it a Bug?*.
9+
The Scala compiler and standard library bug tracker is located at [https://github.com/scala/bug](https://github.com/scala/bug), and for Scala 3, it is located at [github.com/lampepfl/dotty](https://github.com/lampepfl/dotty/issues). Before you submit a bug make sure that it is certainly a bug by following instructions in *Is it a Bug?*.
1010

1111
## Is it a Bug?
1212

@@ -22,7 +22,6 @@ If your issue is related to any of the following external projects, make sure to
2222
- [Akka](https://doc.akka.io/docs/akka/current/project/issue-tracking.html)
2323
- [Play!](https://github.com/playframework/Play20/issues)
2424
- [Slick](https://github.com/slick/slick/issues)
25-
- [Scala IDE](https://scala-ide-portfolio.assembla.com/spaces/scala-ide/support/tickets)
2625
- [sbt](https://github.com/sbt/sbt/issues)
2726

2827
The following are generally considered to be bugs:
@@ -53,10 +52,10 @@ In general, if you find yourself stuck on any of these steps, asking on [Scala C
5352
- For compiler bugs use the [Compiler Category](https://contributors.scala-lang.org/c/compiler).
5453

5554
* Examples of exceptions reported by the compiler which usually are not bugs:
56-
1. `StackOverflowError` is typically not a bug unless the stacktrace involves the internal packages of the compiler (like `scala.tools.nsc...`). Try to increase the Java stack size (`-Xss`), in most of the cases it helps.
55+
1. `StackOverflowError` is typically not a bug unless the stacktrace involves the internal packages of the compiler (like `scala.tools.nsc...`, or `dotty.tools.dotc...`). Try to increase the Java stack size (`-Xss`), in most of the cases it helps.
5756
2. `AbstractMethodError` can occur when you did not recompile all the necessary Scala files (build tools, like `sbt`, can prevent that from happening) or you are mixing external libraries compiled for different Scala versions (for example one uses `2.10.x` and the other `2.11.x`).
5857

59-
## Reporting Confirmed Bugs is a Sin
58+
## Please Check Before Reporting a Bug
6059

6160
Before reporting your bug, make sure to check the issue tracker for other similar bugs. The exception name or a compiler phase are the best keywords to search for. If you are experiencing unexpected behavior search for method/class names where it happens. Your issue might already be reported, and a workaround might already be available for you take advantage of. If your issue *is* reported, be sure to add your test case as a comment if it is different from any of the existing ones.
6261

@@ -68,7 +67,7 @@ If you cannot find your issue in the issue tracker, create a new bug. The detail
6867

6968
Please make sure to fill in as many fields as possible. Make sure you've indicated the following:
7069

71-
1. **Exact Scala version** that you are using. For example, `2.10.1` or `2.11.0-RC`. If the bug happens in multiple versions indicate all of them.
70+
1. **Exact Scala version** that you are using. For example, `2.13.8` or `3.1.2-RC1`. If the bug happens in multiple versions indicate all of them.
7271
2. **The component** that is affected by the bug. For example, the Standard Library, Scaladoc, etc.
7372
3. **Labels** related to your issue. For example, if you think your issue is related to the typechecker, and if you have successfully minimized your issue, label your bug as "typechecker" and "minimized". Issue tracker will suggest names for existing labels as you type them so try not to create duplicates.
7473
4. **Running environment**. Are you running on Linux? Windows? What JVM version are you using?
@@ -78,12 +77,14 @@ In order for us to quickly triage the bug that you've found, it's important that
7877
### Description
7978

8079
In the description of your issue, be as detailed as you can. Bug reports which have the following information included are typically understood, triaged, and fixed very quickly:
81-
82-
1. Include a test case (minimized if possible) enabling us to reproduce the problematic behavior. Include your test case (and output) in proper formatting `{code}` blocks:
83-
84-
{code}Here you put your classes{code}
85-
86-
2. The expected output.
87-
3. The actual output, including the stacktrace.
88-
4. Related discussion on the mailing lists, if applicable.
89-
5. If you have already looked into the issue provide interesting insights or proposals for fixing the issue.
80+
1. Include a test case (minimized if possible) enabling us to reproduce the problematic behavior. Include your test
81+
case (and output) in properly formatted code blocks:
82+
~~~
83+
```scala
84+
List(1, 2, 3).map(x => x + 1)
85+
```
86+
~~~
87+
2. The expected output.
88+
3. The actual output, including the stacktrace.
89+
4. Related discussion on the mailing lists, if applicable.
90+
5. If you have already looked into the issue provide interesting insights or proposals for fixing the issue.

_overviews/contribute/codereviews.md

Lines changed: 26 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -29,27 +29,32 @@ own pull requests.
2929
## Pull Requests Awaiting Comment
3030

3131
<div class="container">
32-
<div class="row">
33-
<div class="span4 doc-block">
34-
<h4><a href="https://github.com/scala/scala/pulls">scala/scala</a></h4>
35-
<p>Scala bug fixes and changes in the language, core libs and included tools.</p>
36-
</div>
37-
<div class="span4 doc-block">
38-
<h4><a href="https://github.com/scala/scala.github.com/pulls">scala/scala.github.com</a></h4>
39-
<p>Scala documentation site.</p>
40-
</div>
41-
</div>
42-
43-
<div class="row">
44-
<div class="span4 doc-block">
45-
<h4><a href="https://github.com/scala/scala-lang/pulls">scala/scala-lang</a></h4>
46-
<p>The Scala language web site.</p>
47-
</div>
48-
<div class="span4 doc-block">
49-
<h4><a href="https://github.com/scala">All Scala GitHub Projects</a></h4>
50-
<p>For other PRs, follow the scala project from here.</p>
51-
</div>
52-
</div>
32+
<div class="row">
33+
<div class="span4 doc-block">
34+
<h4><a href="https://github.com/scala/scala/pulls">lampepfl/dotty</a></h4>
35+
<p>Scala 3 bug fixes and changes in the language, core libs and included tools.</p>
36+
</div>
37+
<div class="span4 doc-block">
38+
<h4><a href="https://github.com/scala/scala/pulls">scala/scala</a></h4>
39+
<p>Scala 2 bug fixes and changes in the language, core libs and included tools.</p>
40+
</div>
41+
</div>
42+
<div class="row">
43+
<div class="span4 doc-block">
44+
<h4><a href="https://github.com/scala/scala-lang/pulls">scala/scala-lang</a></h4>
45+
<p>The Scala language web site.</p>
46+
</div>
47+
<div class="span4 doc-block">
48+
<h4><a href="https://github.com/scala/docs.scala-lang.org/pulls">scala/docs.scala-lang.org</a></h4>
49+
<p>Scala documentation site.</p>
50+
</div>
51+
</div>
52+
<div class="row">
53+
<div class="span4 doc-block">
54+
<h4><a href="https://github.com/scala">All Scala GitHub Projects</a></h4>
55+
<p>For other PRs, follow the scala project from here.</p>
56+
</div>
57+
</div>
5358
</div>
5459

5560
Also note that the [Tools contributions](/overviews/contribute/tools.html) page has more projects that will generate pull requests.

_overviews/contribute/guide.md

Lines changed: 18 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -6,29 +6,13 @@ partof: scala-contribution
66
overview-name: Contributing to Scala
77
---
88

9-
<div class="container">
10-
<div class="row">
11-
<div class="span4 doc-block">
12-
<h3><a href="https://contributors.scala-lang.org/">Scala Contributors</a></h3>
13-
<p>Get a peek into the inners of the Scala compiler.</p>
14-
</div>
15-
<div class="span4 doc-block">
16-
<h3><a href="/overviews/contribute/bug-reporting-guide.html">Report an issue</a></h3>
17-
<p>File a bug report or a feature request.</p>
18-
</div>
19-
</div>
20-
21-
<div class="row">
22-
<div class="span4 doc-block">
23-
<h3><a href="/overviews/contribute/index.html#community-tickets">Community issues</a></h3>
24-
<p>Get cracking on some easy to approach issues.</p>
25-
</div>
26-
<div class="span4 doc-block">
27-
<h3><a href="/overviews/contribute/hacker-guide.html">Hacker guide</a></h3>
28-
<p>Learn to write good code and improve your chances of contributing to the Scala galaxy.</p>
29-
</div>
30-
</div>
31-
</div>
9+
| **Shortcut** | **Description** |
10+
|----------------------------------------|-----------------|
11+
| [Scala Contributors][contrib-forum] | Get a peek into the inners of the Scala compiler. |
12+
| [Report an Issue][bug-reporting-guide] | File a bug report or a feature request. |
13+
| [Community Issues][community-tickets] | Get cracking on some easy to approach issues. |
14+
| [Scala 2 Hacker's Guide][hackers] | Learn to write good code and improve your chances of contributing to the Scala galaxy. |
15+
| [Scala 3 Contributing Guide][scala3-hackers] | Walkthrough contributing to the Scala 3 compiler, along with a guide to compiler internals. |
3216

3317

3418

@@ -52,11 +36,13 @@ which allows us to ensure that all code submitted to the project is
5236
unencumbered by copyrights or patents.
5337

5438
### Bug-fix Check List
39+
> Originally these steps cover the [Scala 2 compiler](https://github.com/scala/scala), but they also are relevant to
40+
> the [Scala 3 compiler](https://github.com/lampepfl/dotty).
5541
5642
This is the impatient developer's checklist for the steps to submit a bug-fix pull request to the Scala project. For more information, description and justification for the steps, follow the links in that step. Further specific instructions for the release of Scala you are targeting can be found in the `CONTRIBUTING.md` file for that [GitHub branch](https://github.com/scala/scala)
5743

5844
1. [Select a bug to fix from GitHub](/overviews/contribute/index.html#community-tickets), or if you found the bug yourself and want to fix it, [create a GitHub issue](/overviews/contribute/bug-reporting-guide.html) (but please
59-
[make sure it's not a duplicate](/overviews/contribute/bug-reporting-guide.html#reporting-confirmed-bugs-is-a-sin)).
45+
[make sure it's not a duplicate](/overviews/contribute/bug-reporting-guide.html#please-check-before-reporting-a-bug)).
6046
2. Optional ([but recommended](/overviews/contribute/scala-internals.html/#why-its-a-good-idea)), announce your intention to work on the bug on [Scala Contributors](https://contributors.scala-lang.org/). After all, don't you want to work on a team with
6147
[these friendly people](/overviews/contribute/hacker-guide.html#1-connect) - it's one of the perks of contributing.
6248
3. [Fork the Scala repository](/overviews/contribute/hacker-guide.html#fork) and clone your fork (if you haven't already).
@@ -70,7 +56,7 @@ https://github.com/scala/scala#git-hygiene). For bug fixes, a single commit is r
7056
10. [Work with a reviewer](https://github.com/scala/scala#reviewing) to [get your pull request merged in](/overviews/contribute/hacker-guide.html#review).
7157
11. Celebrate!
7258

73-
Need more information or a little more hand-holding for the first one? We got you covered: take a read through the entire [Hacker Guide](/overviews/contribute/hacker-guide.html) for an example of implementing a new feature (some of the steps can be skipped for bug fixes, this will be obvious from reading it, but many of the steps here will help with bug fixes too).
59+
Need more information or a little more hand-holding for the first one? We got you covered: take a read through the entire [Hacker Guide][hackers] (or the [equivalent Scala 3 Contributing Guide][scala3-hackers]) for an example of implementing a new feature (some of the steps can be skipped for bug fixes, this will be obvious from reading it, but many of the steps here will help with bug fixes too).
7460

7561
### Larger Changes, New Features
7662

@@ -79,4 +65,10 @@ and on the implementation plan. Announce the change
7965
on the [Scala Contributors](https://contributors.scala-lang.org/) mailing list and get developer feedback. For really complex changes, a [Scala Improvement Process (SIP)](https://docs.scala-lang.org/sips/) document might be required, but the first step is always to discuss it on the mailing list and if a SIP is required, that will be discussed on the mailing list.
8066

8167
Contributions, big or small, simple or complex, controversial or undisputed, need to materialize as patches against
82-
the Scala project source tree. The [hacker guide](/overviews/contribute/hacker-guide.html) will explain how to materialize your idea into a full-fledged pull request against the Scala code base.
68+
the Scala project source tree. The hacker's guides ([Scala 2][hackers], or [Scala 3][scala3-hackers]) will explain how to materialize your idea into a full-fledged pull request against the Scala code base.
69+
70+
[hackers]: /overviews/contribute/hacker-guide.html
71+
[community-tickets]: /overviews/contribute/index.html#community-tickets
72+
[bug-reporting-guide]: /overviews/contribute/bug-reporting-guide.html
73+
[scala3-hackers]: {% link _overviews/scala3-contribution/procedures-intro.md %}
74+
[contrib-forum]: https://contributors.scala-lang.org/

_overviews/contribute/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ When contributing, please follow:
3737

3838
### Community Tickets
3939

40-
All issues can be found in the [Scala bug tracker](https://github.com/scala/bug). Most issues are labeled
40+
All issues can be found in the [Scala bug tracker](https://github.com/scala/bug), or the [Scala 3 issue tracker](https://github.com/lampepfl/dotty/issues). Most issues are labeled
4141
to make it easier to find issues you are interested in.
4242

4343
### Tools and Libraries

0 commit comments

Comments
 (0)