Skip to content

Commit 74ca0de

Browse files
julienrfsjrd
andauthored
Apply suggestions from code review
Co-Authored-By: Sébastien Doeraene <sjrdoeraene@gmail.com>
1 parent 708b973 commit 74ca0de

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

_sips/minutes/2019-06-08-sip-minutes.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ Martin: Hmm, we might not need inline on parameters
206206

207207
[https://dotty.epfl.ch/docs/reference/metaprogramming/macros.html](https://dotty.epfl.ch/docs/reference/metaprogramming/macros.html)
208208

209-
Presented by Oliver
209+
Presented by Olivier
210210

211211
Miles: the example is too basic, no recursion: can we do typeclass derivation with this? (need recursion)
212212

@@ -222,7 +222,7 @@ Adriaan/Seb: inline is simpler
222222

223223
### More general meta-programming talks
224224

225-
Nicolas/Oliver present 3 "tiers" of meta-programming: inline, staging, dotty reflect
225+
Nicolas/Olivier present 3 "tiers" of meta-programming: inline, staging, dotty reflect
226226

227227
At the end it becomes clear that these aren't desugarings from one to another (e.g. staging doesn't desugar
228228
to dotty reflect, it's its own thing, idem for inline to staging).
@@ -259,7 +259,7 @@ Martin: But we said we weren't adding anything to the standard library in 3.0
259259

260260
Olivier: Are they necessary?
261261
* Yes's and No's
262-
* Seb: in Scala.js I could use the
262+
* Seb: in Scala.js I could use them
263263
* Seth: should we ask the community?
264264
* Miles: no, because you'll always find someone that says yes
265265
Decision: Find use cases and test performance
@@ -284,4 +284,3 @@ Without extending it has a subset of java.lang.Enum's API.
284284
You use `-Xsource V` and `-migration` to help get to version V
285285
Martin: I'd like a way to do it file-by-file
286286
* (Many): having different files use different versions of Scala sounds very confusing
287-

0 commit comments

Comments
 (0)