Skip to content

Commit 573e494

Browse files
committed
use jekyll link tag to render internal links
1 parent 302bfbf commit 573e494

File tree

12 files changed

+94
-44
lines changed

12 files changed

+94
-44
lines changed

_contribute_resources/1-documentation.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,7 @@ title: Documentation
33
link: /contribute/documentation.html
44
icon: fa fa-book
55
---
6-
[Scaladoc (API)](/contribute/scala-standard-library-api-documentation.html), [docs.scala-lang.org](/contribute/add-guides.html) and [scala-lang.org](https://github.com/scala/scala-lang).
6+
[Scaladoc (API)][scala-standard-library-api-documentation], [docs.scala-lang.org][add-guides] and [scala-lang.org](https://github.com/scala/scala-lang).
7+
8+
[add-guides]: {% link _overviews/contribute/add-guides.md %}
9+
[scala-standard-library-api-documentation]: {% link _overviews/contribute/scala-standard-library-api-documentation.md %}

_contribute_resources/2-bug-fixes.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,6 @@ title: Bug fixes
33
link: /contribute/guide.html
44
icon: fa fa-bug
55
---
6-
Issues with the tools, core libraries and compiler. Also you can help us by [reporting bugs](/contribute/bug-reporting-guide.html).
6+
Issues with the tools, core libraries and compiler. Also you can help us by [reporting bugs][bug-reporting-guide].
7+
8+
[bug-reporting-guide]: {% link _overviews/contribute/bug-reporting-guide.md %}

_includes/column-list-of-items.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ <h4>{{item.title}}</h4>
1515
</div>
1616
</div>
1717
{% endfor %}
18-
</div>
18+
</div>

_overviews/contribute/add-guides.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ num: 7
55

66
## Why Contribute New Learning Material?
77

8-
As [Heather Miller writes](/contribute.html), contributing to [docs.scala-lang.org](https://docs.scala-lang.org) is
8+
As [Heather Miller writes][why-contribute], contributing to [docs.scala-lang.org][home] is
99
critical to making Scala accessible to newcomers, experience programmers, and anyone who is curious.
1010
It is also a fantastic way to contribute for anyone who is comfortable using Scala, but maybe does not want to get
1111
involved with complex tools like the compiler.
@@ -45,7 +45,7 @@ For one to contribute a document, one must simply
4545
[repo](https://github.com/scala/docs.scala-lang), write their article in
4646
[Markdown](https://daringfireball.net/projects/markdown/syntax) (example below), and submit a pull request. That's it.
4747
Likely after some edits and discussion, your document will be made live
48-
on [docs.scala-lang.org](https://docs.scala-lang.org).
48+
on [docs.scala-lang.org][home].
4949

5050
---
5151
layout: overview
@@ -71,7 +71,7 @@ styling is already taken care of for you.
7171
### Criteria for Docs to be Accepted
7272

7373
The goal of this documentation repository is to be tighter and more organized than other community-driven documentation platforms, like wikis. As such, any document pulled in for inclusion on
74-
[docs.scala-lang.org](https://docs.scala-lang.org) must:
74+
[docs.scala-lang.org][home] must:
7575

7676
- **"fit in"** to the repository ( _i.e.,_ it should not be a complete duplicate of another article),
7777
- **be polished** it must be thorough, complete, correct, organized, and "article-like" (personal programming notes
@@ -129,7 +129,7 @@ documents in the large overview. Putting it on the last page in the overview is
129129
outof: 15
130130
---
131131

132-
Index pages, such as [docs.scala-lang.org/overviews/index.html](https://docs.scala-lang.org/overviews/index.html) are
132+
Index pages, such as [docs.scala-lang.org/overviews/index.html][overviews-index] are
133133
generated, by reading data from a configuration file, such as `_data/overviews.yml`, so your overview should be
134134
placed into a category there.
135135

@@ -216,3 +216,6 @@ above. Here is an example using the various modifiers.
216216

217217
[collections-overview]: {% link _overviews/collections-2.13/introduction.md %}
218218
[scala-with-maven]: {% link _overviews/tutorials/scala-with-maven.md %}
219+
[why-contribute]: {% link contribute.md %}
220+
[home]: {% link index.md %}
221+
[overviews-index]: {% link _overviews/index.md %}

_overviews/contribute/bug-reporting-guide.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ If you have a code snippet that is resulting in bytecode which you believe is be
4141

4242
5. If you want to file an improvement in the issue tracker please discuss it first on one of the mailing lists. They offer much bigger audience than issue tracker. The latter is not suitable for long discussions.
4343

44-
* Keep in mind that the behavior you are witnessing could be intended. Good formal resources for verifying whether or not the language behavior is intended is either in the [Scala Improvement Proposal Documents](https://docs.scala-lang.org/sips/) or in the [Scala Language Specification](https://www.scala-lang.org/files/archive/spec/2.13/). If in doubt, you may always ask on the [Community Category](https://contributors.scala-lang.org/c/community) or [Stack Overflow](https://stackoverflow.com/questions/tagged/scala).
44+
* Keep in mind that the behavior you are witnessing could be intended. Good formal resources for verifying whether or not the language behavior is intended is either in the [Scala Improvement Proposal Documents][sips] or in the [Scala Language Specification](https://www.scala-lang.org/files/archive/spec/2.13/). If in doubt, you may always ask on the [Community Category](https://contributors.scala-lang.org/c/community) or [Stack Overflow](https://stackoverflow.com/questions/tagged/scala).
4545

4646
In general, if you find yourself stuck on any of these steps, asking on [Scala Contributors](https://contributors.scala-lang.org/) can be helpful:
4747

@@ -85,3 +85,5 @@ List(1, 2, 3).map(x => x + 1)
8585
3. The actual output, including the stacktrace.
8686
4. Related discussion on the mailing lists, if applicable.
8787
5. If you have already looked into the issue provide interesting insights or proposals for fixing the issue.
88+
89+
[sips]: {% link _sips/index.md %}

_overviews/contribute/codereviews.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ num: 3
44
---
55
## Code Review Contributions
66

7-
In addition to [bug fixing](/contribute/guide.html), you can help us review
7+
In addition to [bug fixing][bug-fixing], you can help us review
88
[waiting pull requests](#pull-requests-awaiting-comment).
99
This is also a good (and recommended) way to get to know the feel of
1010
the bug-fixing and submissions process before jumping in with your
@@ -54,4 +54,7 @@ own pull requests.
5454
</div>
5555
</div>
5656

57-
Also note that the [Tools contributions](/contribute/tools.html) page has more projects that will generate pull requests.
57+
Also note that the [Tools contributions][tools] page has more projects that will generate pull requests.
58+
59+
[bug-fixing]: {% link _overviews/contribute/guide.md %}
60+
[tools]: {% link _overviews/contribute/tools.md %}

_overviews/contribute/corelibs.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,16 @@ num: 4
66

77
There are several options for contributing to Scala's core libraries. You can:
88

9-
* Help with [Documentation](/contribute/documentation.html).
10-
* [Report Bugs or Issues](/contribute/bug-reporting-guide.html) against the core libraries.
11-
* [Fix Bugs or Issues](/contribute/guide.html) against the
9+
* Help with [Documentation][documentation].
10+
* [Report Bugs or Issues][bug-reporting-guide] against the core libraries.
11+
* [Fix Bugs or Issues][guide] against the
1212
[reported library bugs/issues](https://github.com/scala/bug).
1313

1414
### Significant changes
1515

1616
For significant new functionality or a whole new API to be considered for inclusion in the core Scala distribution,
1717
please take into account [https://github.com/scala/scala-dev/issues/661] before doing so.
18+
19+
[documentation]: {% link _overviews/contribute/documentation.md %}
20+
[bug-reporting-guide]: {% link _overviews/contribute/bug-reporting-guide.md %}
21+
[guide]: {% link _overviews/contribute/guide.md %}

_overviews/contribute/documentation.md

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@ Thanks
2020

2121
The Scala API documentation lives with the scala project source code. There are many ways you can help with improving Scaladoc, including:
2222

23-
* [Log issues for missing scaladoc documentation](/contribute/scala-standard-library-api-documentation.html#contribute-api-documentation-bug-reports) -
23+
* [Log issues for missing scaladoc documentation][report-api-doc-bugs] -
2424
Please *follow the issue submission process closely* to help prevent duplicate issues being created.
25-
* [Claim Scaladoc Issues and Provide Documentation](/contribute/scala-standard-library-api-documentation.html) - please claim issues prior to working on a specific scaladoc task to prevent duplication of effort. If you sit on an issue for too long without submitting a pull request, it will revert back to unassigned and you will need to re-claim it.
25+
* [Claim Scaladoc Issues and Provide Documentation][scala-standard-library-api-documentation] - please claim issues prior to working on a specific scaladoc task to prevent duplication of effort. If you sit on an issue for too long without submitting a pull request, it will revert back to unassigned and you will need to re-claim it.
2626
* You can also just
27-
[submit new Scaladoc](/contribute/scala-standard-library-api-documentation.html)
27+
[submit new Scaladoc][scala-standard-library-api-documentation]
2828
without creating an issue, but please look to see if there is an issue already submitted for your task and claim it if there is. If not, please post your intention to work on a specific scaladoc task on [Scala Contributors](https://contributors.scala-lang.org/) so that people know what you are doing.
2929

3030
### The Main Scala Documentation Site
3131

32-
[docs.scala-lang.org](https://docs.scala-lang.org/) houses the primary source of written, non-API documentation for Scala. It's a GitHub project that you can fork and submit pull requests from. It includes:
32+
[docs.scala-lang.org][home] houses the primary source of written, non-API documentation for Scala. It's a GitHub project that you can fork and submit pull requests from. It includes:
3333

3434
* Overviews
3535
* Tutorials
@@ -41,7 +41,7 @@ without creating an issue, but please look to see if there is an issue already s
4141
* SIP (Scala Improvement Process) Proposals
4242
and more
4343

44-
Please read [Add New Guides/Tutorials](/contribute/add-guides.html) through before embarking on changes. The site uses
44+
Please read [Add New Guides/Tutorials][add-guides] through before embarking on changes. The site uses
4545
the [Jekyll](https://jekyllrb.com/) markdown engine so you will need to follow the instructions to get that running as well.
4646

4747
### Updating scala-lang.org
@@ -52,4 +52,9 @@ to Scala and related projects) is provided on the main
5252
[scala-lang GitHub project](https://github.com/scala/scala-lang) which may be forked to create pull requests.
5353

5454
Please read both the
55-
[Add New Guides/Tutorials](/contribute/add-guides.html) document and the [scala-lang.org GitHub README](https://github.com/scala/scala-lang#scala-langorg) before embarking on any changes to the Scala language site, as it uses the same Jekyll markdown tool and many of the same conventions as the Scala documentation site.
55+
[Add New Guides/Tutorials][add-guides] document and the [scala-lang.org GitHub README](https://github.com/scala/scala-lang#scala-langorg) before embarking on any changes to the Scala language site, as it uses the same Jekyll markdown tool and many of the same conventions as the Scala documentation site.
56+
57+
[report-api-doc-bugs]: {% link _overviews/contribute/scala-standard-library-api-documentation.md %}#contribute-api-documentation-bug-reports
58+
[scala-standard-library-api-documentation]: {% link _overviews/contribute/scala-standard-library-api-documentation.md %}
59+
[home]: {% link index.md %}
60+
[add-guides]: {% link _overviews/contribute/add-guides.md %}

_overviews/contribute/guide.md

Lines changed: 28 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,19 @@ unencumbered by copyrights or patents.
3838
3939
This is the impatient developer's checklist for the steps to submit a bug-fix pull request to the Scala project. For more information, description and justification for the steps, follow the links in that step. Further specific instructions for the release of Scala you are targeting can be found in the `CONTRIBUTING.md` file for that [GitHub branch](https://github.com/scala/scala)
4040

41-
1. [Select a bug to fix from GitHub](/contribute/index.html#community-tickets), or if you found the bug yourself and want to fix it, [create a GitHub issue](/contribute/bug-reporting-guide.html) (but please
42-
[make sure it's not a duplicate](/contribute/bug-reporting-guide.html#please-check-before-reporting-a-bug)).
43-
2. Optional ([but recommended](/contribute/scala-internals.html/#why-its-a-good-idea)), announce your intention to work on the bug on [Scala Contributors](https://contributors.scala-lang.org/). After all, don't you want to work on a team with
44-
[these friendly people](/contribute/hacker-guide.html#1-connect) - it's one of the perks of contributing.
45-
3. [Fork the Scala repository](/contribute/hacker-guide.html#fork) and clone your fork (if you haven't already).
46-
4. [Create a feature branch](/contribute/hacker-guide.html#branch) to work on: use the branch name `issue/NNNN` where NNNN is the GitHub issue number.
47-
5. [Fix the bug, or implement the new small feature](/contribute/hacker-guide.html#implement), include new tests (yes, for bug fixes too).
48-
6. [Test, rinse](/contribute/hacker-guide.html#test) and [test some more](/contribute/partest-guide.html) until [all the tests pass](/contribute/hacker-guide.html#verify).
49-
7. [Commit your changes](/contribute/hacker-guide.html#commit) to your feature branch in your fork. Please choose your commit message based on the [Git Hygiene](https://github.com/scala/scala#user-content-git-hygiene) section of the Scala project README.
41+
1. [Select a bug to fix from GitHub][community-tickets], or if you found the bug yourself and want to fix it, [create a GitHub issue][bug-reporting-guide] (but please
42+
[make sure it's not a duplicate][bug-report-check-dupes]).
43+
2. Optional ([but recommended][why-its-a-good-idea]), announce your intention to work on the bug on [Scala Contributors](https://contributors.scala-lang.org/). After all, don't you want to work on a team with
44+
[these friendly people][hackers-connect] - it's one of the perks of contributing.
45+
3. [Fork the Scala repository][hackers-fork] and clone your fork (if you haven't already).
46+
4. [Create a feature branch][hackers-branch] to work on: use the branch name `issue/NNNN` where NNNN is the GitHub issue number.
47+
5. [Fix the bug, or implement the new small feature][hackers-implement], include new tests (yes, for bug fixes too).
48+
6. [Test, rinse][hackers-test] and [test some more][partest-guide] until [all the tests pass][hackers-verify].
49+
7. [Commit your changes][hackers-commit] to your feature branch in your fork. Please choose your commit message based on the [Git Hygiene](https://github.com/scala/scala#user-content-git-hygiene) section of the Scala project README.
5050
8. If necessary [re-write git history](https://git-scm.com/book/en/Git-Branching-Rebasing) so that [commits are organized by major steps to the fix/feature](
5151
https://github.com/scala/scala#git-hygiene). For bug fixes, a single commit is requested, for features several commits may be desirable (but each separate commit must compile and pass all tests)
52-
9. [Submit a pull request](/contribute/hacker-guide.html#submit).
53-
10. [Work with a reviewer](https://github.com/scala/scala#reviewing) to [get your pull request merged in](/contribute/hacker-guide.html#review).
52+
9. [Submit a pull request][hackers-submit].
53+
10. [Work with a reviewer](https://github.com/scala/scala#reviewing) to [get your pull request merged in][hackers-review].
5454
11. Celebrate!
5555

5656
Need more information or a little more hand-holding for the first one? We got you covered: take a read through the entire [Hacker Guide][hackers] (or the [equivalent Scala 3 Contributing Guide][scala3-hackers]) for an example of implementing a new feature (some of the steps can be skipped for bug fixes, this will be obvious from reading it, but many of the steps here will help with bug fixes too).
@@ -59,13 +59,26 @@ Need more information or a little more hand-holding for the first one? We got yo
5959

6060
For larger, more ambitious changes (e.g. new language features), the first step to making a change is to discuss it with the community at large, to make sure everyone agrees on the idea
6161
and on the implementation plan. Announce the change
62-
on the [Scala Contributors](https://contributors.scala-lang.org/) mailing list and get developer feedback. For really complex changes, a [Scala Improvement Process (SIP)](https://docs.scala-lang.org/sips/) document might be required, but the first step is always to discuss it on the mailing list and if a SIP is required, that will be discussed on the mailing list.
62+
on the [Scala Contributors](https://contributors.scala-lang.org/) mailing list and get developer feedback. For really complex changes, a [Scala Improvement Process (SIP)][sips] document might be required, but the first step is always to discuss it on the mailing list and if a SIP is required, that will be discussed on the mailing list.
6363

6464
Contributions, big or small, simple or complex, controversial or undisputed, need to materialize as patches against
6565
the Scala project source tree. The hacker's guides ([Scala 2][hackers], or [Scala 3][scala3-hackers]) will explain how to materialize your idea into a full-fledged pull request against the Scala code base.
6666

67-
[hackers]: /contribute/hacker-guide.html
68-
[community-tickets]: /contribute/index.html#community-tickets
69-
[bug-reporting-guide]: /contribute/bug-reporting-guide.html
67+
[hackers]: {% link _overviews/contribute/hacker-guide.md %}
68+
[community-tickets]: {% link _overviews/contribute/index.md %}#community-tickets
69+
[bug-reporting-guide]: {% link _overviews/contribute/bug-reporting-guide.md %}
70+
[bug-report-check-dupes]: {% link _overviews/contribute/bug-reporting-guide.md %}#please-check-before-reporting-a-bug
7071
[scala3-hackers]: {% link _overviews/scala3-contribution/procedures-intro.md %}
7172
[contrib-forum]: https://contributors.scala-lang.org/
73+
[why-its-a-good-idea]: {% link _overviews/contribute/scala-internals.md %}#why-its-a-good-idea
74+
[hackers-connect]: {% link _overviews/contribute/hacker-guide.md %}#1-connect
75+
[hackers-fork]: {% link _overviews/contribute/hacker-guide.md %}#fork
76+
[hackers-branch]: {% link _overviews/contribute/hacker-guide.md %}#branch
77+
[hackers-implement]: {% link _overviews/contribute/hacker-guide.md %}#implement
78+
[hackers-test]: {% link _overviews/contribute/hacker-guide.md %}#test
79+
[hackers-verify]: {% link _overviews/contribute/hacker-guide.md %}#verify
80+
[hackers-commit]: {% link _overviews/contribute/hacker-guide.md %}#commit
81+
[hackers-submit]: {% link _overviews/contribute/hacker-guide.md %}#submit
82+
[hackers-review]: {% link _overviews/contribute/hacker-guide.md %}#review
83+
[partest-guide]: {% link _overviews/contribute/partest-guide.md %}
84+
[sips]: {% link _sips/index.md %}

0 commit comments

Comments
 (0)