Skip to content

Commit 1476c4d

Browse files
committed
Merge branch 'main' into update/scala-library-2.13.7
2 parents c9a3d1e + f07411f commit 1476c4d

File tree

6 files changed

+70
-16
lines changed

6 files changed

+70
-16
lines changed

.github/workflows/ci.yml

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ jobs:
2626
strategy:
2727
matrix:
2828
os: [ubuntu-latest]
29-
scala: [2.11.12, 2.12.14, 2.13.7, 3.0.2]
30-
java: [adopt@1.8]
29+
scala: [2.11.12, 2.12.14, 2.13.6, 3.0.2]
30+
java: [temurin@11]
3131
ci: [ciNode, ciFirefox, ciChrome, ciJSDOMNodeJS]
3232
runs-on: ${{ matrix.os }}
3333
steps:
@@ -36,10 +36,12 @@ jobs:
3636
with:
3737
fetch-depth: 0
3838

39-
- name: Setup Java and Scala
40-
uses: olafurpg/setup-scala@v13
39+
- name: Setup Java (temurin@11)
40+
if: matrix.java == 'temurin@11'
41+
uses: actions/setup-java@v2
4142
with:
42-
java-version: ${{ matrix.java }}
43+
distribution: temurin
44+
java-version: 11
4345

4446
- name: Cache sbt
4547
uses: actions/cache@v2
@@ -76,18 +78,20 @@ jobs:
7678
matrix:
7779
os: [ubuntu-latest]
7880
scala: [3.0.2]
79-
java: [adopt@1.8]
81+
java: [temurin@11]
8082
runs-on: ${{ matrix.os }}
8183
steps:
8284
- name: Checkout current branch (full)
8385
uses: actions/checkout@v2
8486
with:
8587
fetch-depth: 0
8688

87-
- name: Setup Java and Scala
88-
uses: olafurpg/setup-scala@v13
89+
- name: Setup Java (temurin@11)
90+
if: matrix.java == 'temurin@11'
91+
uses: actions/setup-java@v2
8992
with:
90-
java-version: ${{ matrix.java }}
93+
distribution: temurin
94+
java-version: 11
9195

9296
- name: Cache sbt
9397
uses: actions/cache@v2

README.md

Lines changed: 53 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,64 @@ The `loop()` future will run forever when using the default Scala.js executor, w
4646

4747
This explains why the above snippet will run forever on a `Promise`-based executor: the microtask queue is *never* empty because we're constantly adding new tasks! Thus, `setTimeout` is never able to run because the macrotask queue never receives control.
4848

49-
This is fixable by using a `setTimeout`-based executor, such as the `QueueExecutionContext.timeouts()` implementation in Scala.js. Unfortunately, this runs into an even more serious issue: `setTimeout` is *clamped* in all JavaScript environments. In particular, it is clamped to a minimum of 4ms and, in practice, usually somewhere between 4ms and 10ms. This clamping kicks in whenever more than 5 consecutive timeouts have been scheduled. You can read more details [in the MDM documentation](https://developer.mozilla.org/en-US/docs/Web/API/WindowTimers.setTimeout#Minimum.2F_maximum_delay_and_timeout_nesting).
49+
### `setTimeout`
50+
51+
This is fixable by using a `setTimeout`-based executor, such as the `QueueExecutionContext.timeouts()` implementation in Scala.js. Available in all browsers since the dawn of time, `setTimeout` takes two arguments: a time delay and a callback to invoke. The callback is invoked by the event loop once the time delay expires, and this is implemented by pushing the callback onto the back of the event queue at the appropriate time. Calling `setTimeout` with a delay of `0` would seem to achieve *exactly* the semantics we want: yield back to the event loop and allow it to resume our callback when it's our turn once again.
52+
53+
Unfortunately, `setTimeout` is slow. Very, very, very slow. The timing mechanism imposes quite a bit of overhead, even when the delay is `0`, and there are other complexities which ultimately impose a performance penalty too severe to accept. Any significant application of an `ExecutionContext` backed by `setTimeout`, would be almost unusable.
54+
55+
To make matters worse, `setTimeout` is *clamped* in all JavaScript environments. In particular, it is clamped to a minimum of 4ms and, in practice, usually somewhere between 4ms and 10ms. This clamping kicks in whenever more than 5 consecutive timeouts have been scheduled:
56+
57+
```javascript
58+
setTimeout(() => {
59+
setTimeout(() => {
60+
setTimeout(() => {
61+
setTimeout(() => {
62+
setTimeout(() => {
63+
// this one (and all after it) are clamped!
64+
}, 0);
65+
}, 0);
66+
}, 0);
67+
}, 0);
68+
}, 0);
69+
```
70+
71+
Each timeout sets a new timeout, and so on and so on. This is exactly the sort of situation that we get into when chaining `Future`s, where each `map`/`flatMap`/`transform`/etc. schedules another `Future` which, in turn will schedule another... etc. etc. This is exactly where we see clamping. In particular, the innermost `setTimeout` in this example will be clamped to 4 milliseconds (meaning there is no difference between `setTimeout(.., 0)` and `setTimeout(.., 4)`), which would slow down execution *even more*.
72+
73+
You can read more details [in the MDN documentation](https://developer.mozilla.org/en-US/docs/Web/API/WindowTimers.setTimeout#Minimum.2F_maximum_delay_and_timeout_nesting).
74+
75+
### `setImmediate`
76+
77+
Fortunately, we aren't the only ones to have this problem. What we *want* is something which uses the macrotask queue (so we play nicely with `setTimeout`, I/O, and other macrotasks), but which doesn't have as much overhead as `setTimeout`. The answer is `setImmediate`.
78+
79+
The `setImmediate` function was first introduced in Node.js, and its purpose is to solve *exactly* this problem: a faster `setTimeout(..., 0)`. In particular, `setImmediate(...)` is *semantically* equivalent to `setTimeout(0, ...)`, except without the associated clamping: it doesn't include a delay mechanism of any sort, it simply takes a callback and immediately submits it to the event loop, which in turn will run the callback as soon as its turn comes up.
5080

51-
The only solution to this mess is to yield to the macrotask queue *without* using `setTimeout`. This is precisely what `setImmediate` does on Edge and Node.js. In particular, `setImmediate(...)` is *semantically* equivalent to `setTimeout(0, ...)`, except without the associated clamping. Unfortunately, due to the fact that only a pair of platforms support this function, alternative implementations are required across other major browsers. In particular, *most* environments take advantage of `postMessage` in some way.
81+
Unfortunately, `setImmediate` isn't available on every platform. For reasons of... their own, Mozilla, Google, and Apple have all strenuously objected to the inclusion of `setImmediate` in the W3C standard set, despite the proposal (which originated at Microsoft) and obvious usefulness. This in turn has resulted in inconsistency across the JavaScript space.
82+
83+
That's the bad news. The good news is that all modern browsers include *some* sort of functionality which can be exploited to emulate `setImmediate` with similar performance characteristics. In particular, *most* environments take advantage of `postMessage` in some way. If you're interested in the nitty-gritty details of how this works, you are referred to [this excellent readme](https://github.com/YuzuJS/setImmediate#the-tricks).
84+
85+
scala-js-macrotask-executor implements *most* of the `setImmediate` polyfill in terms of Scala.js, wrapped up in an `ExecutionContext` interface. The only elements of the polyfill which are *not* implemented are as follows:
86+
87+
- `process.nextTick` is used by the JavaScript polyfill when running on Node.js versions below 0.9. However, Scala.js itself does not support Node.js 0.9 or below, so there's really no point in supporting this case.
88+
- Similarly, older versions of IE (6 through 8, specifically) allow a particular exploitation of the `onreadystatechange` event fired when a `<script>` element is inserted into the DOM. However, Scala.js does not support these environments *either*, and so there is no benefit to implementing this case.
89+
90+
On environments where the polyfill is unsupported, `setTimeout` is still used as a final fallback.
5291

5392
### Performance Notes
5493

94+
Optimal performance is currently available in the following environments:
95+
96+
- [Node.js 0.9.1+](https://Node.js.org/api/timers.html#timers_setimmediate_callback_args)
97+
- [Browsers implementing `window.postMessage()`](https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage#browser_compatibility), including:
98+
- Chrome 1+
99+
- Safari 4+
100+
- Internet Explorer 9+ (including Edge)
101+
- Firefox 3+
102+
- Opera 9.5+
103+
- [Web Workers implementing `MessageChannel`](https://developer.mozilla.org/en-US/docs/Web/API/MessageChannel#browser_compatibility)
104+
55105
`setImmediate` in practice seems to be somewhat slower than `Promise.then()`, particularly on Chrome. However, since `Promise` also has seriously detrimental effects (such as blocking UI rendering), it doesn't seem to be a particularly fair comparison. `Promise` is also *slower* than `setImmediate` on Firefox for very unclear reasons likely having to do with fairness issues in the Gecko engine itself.
56106

57107
`setImmediate` is *dramatically* faster than `setTimeout`, mostly due to clamping but also because `setTimeout` has other sources of overhead. In particular, executing 10,000 sequential tasks takes about 30 seconds with `setTimeout` and about 400 *milliseconds* using `setImmediate`.
58108

59-
See [scala-js#4129](https://github.com/scala-js/scala-js/issues/4129) for some background discussion.
109+
See [scala-js#4129](https://github.com/scala-js/scala-js/issues/4129) for additional background discussion.

build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ lazy val webworker = project
157157
name := "scala-js-macrotask-executor-webworker",
158158
scalaJSUseMainModuleInitializer := true,
159159
libraryDependencies ++= Seq(
160-
("org.scala-js" %%% "scalajs-dom" % "1.2.0").cross(CrossVersion.for3Use2_13),
160+
"org.scala-js" %%% "scalajs-dom" % "2.0.0",
161161
"org.scalameta" %%% "munit" % MUnitVersion % Test,
162162
),
163163
(Test / test) := (Test / test).dependsOn(Compile / fastOptJS).value,

project/plugins.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
libraryDependencies += "org.scala-js" %% "scalajs-env-selenium" % "1.1.1"
22
libraryDependencies += "org.scala-js" %% "scalajs-env-jsdom-nodejs" % "1.1.0"
33

4-
addSbtPlugin("com.codecommit" % "sbt-spiewak-sonatype" % "0.22.1")
4+
addSbtPlugin("com.codecommit" % "sbt-spiewak-sonatype" % "0.23.0")
55
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.7.1")
66
addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.10.0")

webworker/src/main/scala/org/scalajs/macrotaskexecutor/MacrotaskExecutorSuiteRunner.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import munit.MUnitRunner
2020
import org.junit.runner.Description
2121
import org.junit.runner.notification.Failure
2222
import org.junit.runner.notification.RunNotifier
23-
import org.scalajs.dom.webworkers.DedicatedWorkerGlobalScope
23+
import org.scalajs.dom.DedicatedWorkerGlobalScope
2424

2525
import scala.scalajs.js
2626

webworker/src/test/scala/org/scalajs/macrotaskexecutor/WebWorkerMacrotaskSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ package org.scalajs.macrotaskexecutor
1818

1919
import munit.FunSuite
2020
import org.scalajs.dom.MessageEvent
21-
import org.scalajs.dom.webworkers.Worker
21+
import org.scalajs.dom.Worker
2222

2323
import scala.concurrent.Promise
2424

0 commit comments

Comments
 (0)