Merge pull request #575 from scala-js/topic/remove-migrated-implicits

japgolly · web-flow · commit 251145ef4a43 · 2021-09-27T14:13:47.000+10:00
Remove unnecessary implicit conversions
diff --git a/api-reports/2_12.txt b/api-reports/2_12.txt
@@ -24423,8 +24423,8 @@ experimental/PointerLock.PointerLockMouseEvent[JT] def movementY: Double
 experimental/Vibration[SO]  (@deprecated in 2.0.0)
 experimental/beacon/package[SO] type BeaconNavigator = dom.Navigator  (@deprecated in 2.0.0)
 experimental/beacon/package[SO] type BeaconWorkerNavigator = dom.WorkerNavigator  (@deprecated in 2.0.0)
-experimental/beacon/package[SO] implicit def toBeaconNavigator(n: Navigator): BeaconNavigator  (@deprecated in 2.0.0)
-experimental/beacon/package[SO] implicit def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator  (@deprecated in 2.0.0)
+experimental/beacon/package[SO] def toBeaconNavigator(n: Navigator): BeaconNavigator  (@deprecated in 2.0.0)
+experimental/beacon/package[SO] def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator  (@deprecated in 2.0.0)
 experimental/cachestorage/package[SO] type Cache = dom.Cache  (@deprecated in 2.0.0)
 experimental/cachestorage/package[SO] type CacheQueryOptions = dom.CacheQueryOptions  (@deprecated in 2.0.0)
 experimental/cachestorage/package[SO] type CacheStorage = dom.CacheStorage  (@deprecated in 2.0.0)
@@ -24494,7 +24494,7 @@ experimental/gamepad/package[SO] type GamepadEventInit = dom.GamepadEventInit  (
 experimental/gamepad/package[SO] type GamepadMappingType = dom.GamepadMappingType  (@deprecated in 2.0.0)
 experimental/gamepad/package[SO] type GamepadNavigator = dom.Navigator  (@deprecated in 2.0.0)
 experimental/gamepad/package[SO] def standard: dom.GamepadMappingType  (@deprecated in 2.0.0)
-experimental/gamepad/package[SO] implicit def toGamepad(navigator: dom.Navigator): GamepadNavigator  (@deprecated in 2.0.0)
+experimental/gamepad/package[SO] def toGamepad(navigator: dom.Navigator): GamepadNavigator  (@deprecated in 2.0.0)
 experimental/gamepad/package[SO] def unknown: dom.GamepadMappingType  (@deprecated in 2.0.0)
 experimental/intl/Collator[JC] def compare(string1: String, string2: String): Double
 experimental/intl/Collator[JC] def resolvedOptions(): CollatorOptions
diff --git a/api-reports/2_13.txt b/api-reports/2_13.txt
@@ -24423,8 +24423,8 @@ experimental/PointerLock.PointerLockMouseEvent[JT] def movementY: Double
 experimental/Vibration[SO]  (@deprecated in 2.0.0)
 experimental/beacon/package[SO] type BeaconNavigator = dom.Navigator  (@deprecated in 2.0.0)
 experimental/beacon/package[SO] type BeaconWorkerNavigator = dom.WorkerNavigator  (@deprecated in 2.0.0)
-experimental/beacon/package[SO] implicit def toBeaconNavigator(n: Navigator): BeaconNavigator  (@deprecated in 2.0.0)
-experimental/beacon/package[SO] implicit def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator  (@deprecated in 2.0.0)
+experimental/beacon/package[SO] def toBeaconNavigator(n: Navigator): BeaconNavigator  (@deprecated in 2.0.0)
+experimental/beacon/package[SO] def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator  (@deprecated in 2.0.0)
 experimental/cachestorage/package[SO] type Cache = dom.Cache  (@deprecated in 2.0.0)
 experimental/cachestorage/package[SO] type CacheQueryOptions = dom.CacheQueryOptions  (@deprecated in 2.0.0)
 experimental/cachestorage/package[SO] type CacheStorage = dom.CacheStorage  (@deprecated in 2.0.0)
@@ -24494,7 +24494,7 @@ experimental/gamepad/package[SO] type GamepadEventInit = dom.GamepadEventInit  (
 experimental/gamepad/package[SO] type GamepadMappingType = dom.GamepadMappingType  (@deprecated in 2.0.0)
 experimental/gamepad/package[SO] type GamepadNavigator = dom.Navigator  (@deprecated in 2.0.0)
 experimental/gamepad/package[SO] def standard: dom.GamepadMappingType  (@deprecated in 2.0.0)
-experimental/gamepad/package[SO] implicit def toGamepad(navigator: dom.Navigator): GamepadNavigator  (@deprecated in 2.0.0)
+experimental/gamepad/package[SO] def toGamepad(navigator: dom.Navigator): GamepadNavigator  (@deprecated in 2.0.0)
 experimental/gamepad/package[SO] def unknown: dom.GamepadMappingType  (@deprecated in 2.0.0)
 experimental/intl/Collator[JC] def compare(string1: String, string2: String): Double
 experimental/intl/Collator[JC] def resolvedOptions(): CollatorOptions
diff --git a/src/main/scala/org/scalajs/dom/experimental/beacon/package.scala b/src/main/scala/org/scalajs/dom/experimental/beacon/package.scala
@@ -2,8 +2,6 @@ package org.scalajs
 package dom
 package experimental
 
-import scala.language.implicitConversions
-
 package object beacon {
 
   @deprecated("use dom.Navigator instead", "2.0.0")
@@ -13,11 +11,11 @@ package object beacon {
   type BeaconWorkerNavigator = dom.WorkerNavigator
 
   @deprecated("use dom.Navigator directly instead", "2.0.0")
-  implicit def toBeaconNavigator(n: Navigator): BeaconNavigator =
+  def toBeaconNavigator(n: Navigator): BeaconNavigator =
     n
 
   @deprecated("use dom.WorkerNavigator directly instead", "2.0.0")
-  implicit def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator =
+  def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator =
     n
 
 }
diff --git a/src/main/scala/org/scalajs/dom/experimental/gamepad/package.scala b/src/main/scala/org/scalajs/dom/experimental/gamepad/package.scala
@@ -1,8 +1,6 @@
 package org.scalajs
 package dom.experimental
 
-import scala.language.implicitConversions
-
 package object gamepad {
 
   @deprecated("use dom.GamepadMappingType instead", "2.0.0")
@@ -24,7 +22,7 @@ package object gamepad {
   type GamepadNavigator = dom.Navigator
 
   @deprecated("use dom.Navigator directly instead", "2.0.0")
-  implicit def toGamepad(navigator: dom.Navigator): GamepadNavigator =
+  def toGamepad(navigator: dom.Navigator): GamepadNavigator =
     navigator
 
   @deprecated("use dom.GamepadMappingType.`unknown` instead", "2.0.0")

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,6 @@ package org.scalajs`
`2`	`2`	`package dom`
`3`	`3`	`package experimental`
`4`	`4`
`5`		`-import scala.language.implicitConversions`
`6`		`-`
`7`	`5`	`package object beacon {`
`8`	`6`
`9`	`7`	`@deprecated("use dom.Navigator instead", "2.0.0")`
`@@ -13,11 +11,11 @@ package object beacon {`
`13`	`11`	`type BeaconWorkerNavigator = dom.WorkerNavigator`
`14`	`12`
`15`	`13`	`@deprecated("use dom.Navigator directly instead", "2.0.0")`
`16`		`- implicit def toBeaconNavigator(n: Navigator): BeaconNavigator =`
	`14`	`+ def toBeaconNavigator(n: Navigator): BeaconNavigator =`
`17`	`15`	`n`
`18`	`16`
`19`	`17`	`@deprecated("use dom.WorkerNavigator directly instead", "2.0.0")`
`20`		`- implicit def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator =`
	`18`	`+ def toBeaconWorkerNavigator(n: WorkerNavigator): BeaconWorkerNavigator =`
`21`	`19`	`n`
`22`	`20`
`23`	`21`	`}`