Skip to content

Commit 23c2c77

Browse files
Apply suggestions from code review
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
1 parent 1cc5447 commit 23c2c77

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

dom/src/main/scala/org/scalajs/dom/NDEFRecordInit.scala

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ trait NDEFRecordInit extends js.Object {
1313
/** Contains the data to be transmitted. It can be a string object or literal, an ArrayBuffer, a TypedArray, a
1414
* DataView, or an array of nested records.
1515
*/
16-
def data: js.UndefOr[
16+
var data: js.UndefOr[
1717
String |
1818
js.typedarray.DataView |
1919
js.typedarray.ArrayBuffer |
@@ -23,18 +23,18 @@ trait NDEFRecordInit extends js.Object {
2323
] = js.undefined
2424

2525
/** A string specifying the record's encoding. */
26-
def encoding: js.UndefOr[String] = js.undefined
26+
var encoding: js.UndefOr[String] = js.undefined
2727

2828
/** A developer-defined identifier for the record. */
29-
def id: js.UndefOr[String] = js.undefined
29+
var id: js.UndefOr[String] = js.undefined
3030

3131
/** A valid language tag according to [RFC 5646: Tags for Identifying Languages (also known as BCP
3232
* 47)](https://datatracker.ietf.org/doc/html/rfc5646).
3333
*/
34-
def lang: js.UndefOr[String] = js.undefined
34+
var lang: js.UndefOr[String] = js.undefined
3535

3636
/** A valid MIME type. */
37-
def mediaType: js.UndefOr[String] = js.undefined
37+
var mediaType: js.UndefOr[String] = js.undefined
3838

3939
/** A string indicating the type of data stored in data.
4040
*
@@ -47,5 +47,5 @@ trait NDEFRecordInit extends js.Object {
4747
* - "unknown" - The record type is not known.
4848
* - "URL" - A URL as defined by the NDEF-URI specification.
4949
*/
50-
def recordType: js.UndefOr[String] = js.undefined
50+
var recordType: js.UndefOr[String] = js.undefined
5151
}

dom/src/main/scala/org/scalajs/dom/NDEFScanOptions.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ import scala.scalajs.js
55
trait NDEFScanOptions extends js.Object {
66

77
/** An AbortSignal that allows the current write operation to be canceled. */
8-
def `signal`: js.UndefOr[AbortSignal] = js.undefined
8+
var `signal`: js.UndefOr[AbortSignal] = js.undefined
99
}

dom/src/main/scala/org/scalajs/dom/NDEFWriteOptions.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import scala.scalajs.js
66
trait NDEFWriteOptions extends js.Object {
77

88
/** A boolean value specifying whether or not existing records should be overwritten, if such exists. */
9-
def `overwrite`: Boolean
9+
var `overwrite`: Boolean
1010

1111
/** An AbortSignal that allows the current write operation to be canceled. */
12-
def `signal`: js.UndefOr[AbortSignal] = js.undefined
12+
var `signal`: js.UndefOr[AbortSignal] = js.undefined
1313

1414
}

0 commit comments

Comments
 (0)