Skip to content

Commit 909fad5

Browse files
committed
ci: move lints job from rust.yml to qa.yml
We are linting the repo, not just Rust.
1 parent d7a7d75 commit 909fad5

File tree

2 files changed

+29
-29
lines changed

2 files changed

+29
-29
lines changed

.github/workflows/qa.yml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,32 @@ jobs:
88
- uses: actions/checkout@v4
99
# Executes "typos ."
1010
- uses: crate-ci/typos@v1.30.2
11+
lints:
12+
name: Lints
13+
runs-on: ubuntu-latest
14+
steps:
15+
- name: Checkout sources
16+
uses: actions/checkout@v4
17+
- uses: cachix/install-nix-action@v31
18+
- uses: Swatinem/rust-cache@v2
19+
# Dedicated step to separate all the
20+
# "copying path '/nix/store/...' from 'https://cache.nixos.org'."
21+
# messages from the actual build output.
22+
- name: Prepare Nix Store
23+
run: nix develop --command echo
24+
# Executing this in a Nix shell ensures that all our checks run as all
25+
# required tooling exists.
26+
- name: Check formatting
27+
run: |
28+
CMD="cargo xtask fmt --check"
29+
nix develop --command bash -c "$CMD"
30+
- name: Run clippy
31+
run: |
32+
rustup component add clippy
33+
cargo xtask clippy --warnings-as-errors
34+
- name: Run cargo doc (without unstable)
35+
run: cargo xtask doc --warnings-as-errors --document-private-items
36+
- name: Verify generated code is up-to-date
37+
run: cargo xtask gen-code --check
38+
- name: Run additional checks on the uefi-raw package
39+
run: cargo xtask check-raw

.github/workflows/rust.yml

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -81,35 +81,6 @@ jobs:
8181
- uses: Swatinem/rust-cache@v2
8282
- name: Run cargo test (without unstable)
8383
run: cargo xtask test
84-
lints:
85-
name: Lints
86-
runs-on: ubuntu-latest
87-
steps:
88-
- name: Checkout sources
89-
uses: actions/checkout@v4
90-
- uses: cachix/install-nix-action@v31
91-
- uses: Swatinem/rust-cache@v2
92-
# Dedicated step to separate all the
93-
# "copying path '/nix/store/...' from 'https://cache.nixos.org'."
94-
# messages from the actual build output.
95-
- name: Prepare Nix Store
96-
run: nix develop --command echo
97-
# Executing this in a Nix shell ensures that all our checks run as all
98-
# required tooling exists.
99-
- name: Check formatting
100-
run: |
101-
CMD="cargo xtask fmt --check"
102-
nix develop --command bash -c "$CMD"
103-
- name: Run clippy
104-
run: |
105-
rustup component add clippy
106-
cargo xtask clippy --warnings-as-errors
107-
- name: Run cargo doc (without unstable)
108-
run: cargo xtask doc --warnings-as-errors --document-private-items
109-
- name: Verify generated code is up-to-date
110-
run: cargo xtask gen-code --check
111-
- name: Run additional checks on the uefi-raw package
112-
run: cargo xtask check-raw
11384
# Run the build with our current stable MSRV (specified in
11485
# ./msrv_toolchain.toml). This serves to check that we don't
11586
# accidentally start relying on a new feature without intending

0 commit comments

Comments
 (0)