Skip to content

Commit 19adde1

Browse files
committed
multiboot2: remove unused align(8) structs
I decided so as they only make things more complicated for miri. As we have mature builder and parser structs guaranteeing alignment, we do not have to create additional confusion. These align(8) markers do not have value-add here besides being informational. They are only useful if no crazy pointer magic is involved and Rust constructs these types "in the Rust-typical way".
1 parent b595d26 commit 19adde1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

multiboot2/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ impl core::error::Error for MbiLoadError {}
145145

146146
/// The basic header of a boot information.
147147
#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
148-
#[repr(C, align(8))]
148+
#[repr(C)]
149149
pub struct BootInformationHeader {
150150
// size is multiple of 8
151151
total_size: u32,
@@ -1638,7 +1638,7 @@ mod tests {
16381638
fn get_custom_dst_tag_from_mbi() {
16391639
const CUSTOM_TAG_ID: u32 = 0x1337;
16401640

1641-
#[repr(C, align(8))]
1641+
#[repr(C)]
16421642
#[derive(crate::Pointee)]
16431643
struct CustomTag {
16441644
tag: TagTypeId,

0 commit comments

Comments
 (0)