Skip to content

Commit 2cdc6c2

Browse files
Atul9phil-opp
authored andcommitted
Format code using 'cargo fmt' (#54)
1 parent 2340d6b commit 2cdc6c2

File tree

3 files changed

+57
-21
lines changed

3 files changed

+57
-21
lines changed

build.rs

Lines changed: 39 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
use std::{env, path::{Path, PathBuf}, process::{self, Command}};
1+
use std::{
2+
env,
3+
path::{Path, PathBuf},
4+
process::{self, Command},
5+
};
26

37
fn main() {
48
let target = env::var("TARGET").expect("TARGET not set");
@@ -16,14 +20,18 @@ fn main() {
1620
Err(_) => {
1721
eprintln!(
1822
"The KERNEL environment variable must be set for building the bootloader.\n\n\
19-
If you use `bootimage` for building you need at least version 0.7.0. You can \
20-
update `bootimage` by running `cargo install bootimage --force`."
23+
If you use `bootimage` for building you need at least version 0.7.0. You can \
24+
update `bootimage` by running `cargo install bootimage --force`."
2125
);
2226
process::exit(1);
2327
}
2428
});
2529

26-
let kernel_file_name = kernel.file_name().expect("KERNEL has no valid file name").to_str().expect("kernel file name not valid utf8");
30+
let kernel_file_name = kernel
31+
.file_name()
32+
.expect("KERNEL has no valid file name")
33+
.to_str()
34+
.expect("kernel file name not valid utf8");
2735
let kernel_file_name_replaced = kernel_file_name.replace('-', "_");
2836
let kernel_out_path = out_dir.join(format!("kernel_bin-{}.o", kernel_file_name));
2937
let kernel_archive_path = out_dir.join(format!("libkernel_bin-{}.a", kernel_file_name));
@@ -41,16 +49,27 @@ fn main() {
4149
process::exit(1);
4250
}
4351
};
44-
let objcopy = llvm_tools.tool(&llvm_tools::exe("llvm-objcopy")).expect("llvm-objcopy not found in llvm-tools");
52+
let objcopy = llvm_tools
53+
.tool(&llvm_tools::exe("llvm-objcopy"))
54+
.expect("llvm-objcopy not found in llvm-tools");
4555

4656
let mut cmd = Command::new(objcopy);
4757
cmd.arg("-I").arg("binary");
4858
cmd.arg("-O").arg("elf64-x86-64");
4959
cmd.arg("--binary-architecture=i386:x86-64");
5060
cmd.arg("--rename-section").arg(".data=.kernel");
51-
cmd.arg("--redefine-sym").arg(format!("_binary_{}_start=_kernel_start_addr", kernel_file_name_replaced));
52-
cmd.arg("--redefine-sym").arg(format!("_binary_{}_end=_kernel_end_addr", kernel_file_name_replaced));
53-
cmd.arg("--redefine-sym").arg(format!("_binary_{}_size=_kernel_size", kernel_file_name_replaced));
61+
cmd.arg("--redefine-sym").arg(format!(
62+
"_binary_{}_start=_kernel_start_addr",
63+
kernel_file_name_replaced
64+
));
65+
cmd.arg("--redefine-sym").arg(format!(
66+
"_binary_{}_end=_kernel_end_addr",
67+
kernel_file_name_replaced
68+
));
69+
cmd.arg("--redefine-sym").arg(format!(
70+
"_binary_{}_size=_kernel_size",
71+
kernel_file_name_replaced
72+
));
5473
cmd.current_dir(kernel.parent().expect("KERNEL has no valid parent dir"));
5574
cmd.arg(&kernel_file_name);
5675
cmd.arg(&kernel_out_path);
@@ -60,12 +79,14 @@ fn main() {
6079
process::exit(1);
6180
}
6281

63-
let ar = llvm_tools.tool(&llvm_tools::exe("llvm-ar")).unwrap_or_else(|| {
64-
eprintln!("Failed to retrieve llvm-ar component");
65-
eprint!("This component is available since nightly-2019-03-29,");
66-
eprintln!("so try updating your toolchain if you're using an older nightly");
67-
process::exit(1);
68-
});
82+
let ar = llvm_tools
83+
.tool(&llvm_tools::exe("llvm-ar"))
84+
.unwrap_or_else(|| {
85+
eprintln!("Failed to retrieve llvm-ar component");
86+
eprint!("This component is available since nightly-2019-03-29,");
87+
eprintln!("so try updating your toolchain if you're using an older nightly");
88+
process::exit(1);
89+
});
6990
let mut cmd = Command::new(ar);
7091
cmd.arg("crs");
7192
cmd.arg(&kernel_archive_path);
@@ -80,5 +101,8 @@ fn main() {
80101
println!("cargo:rerun-if-changed={}", kernel.display());
81102
println!("cargo:rerun-if-changed=build.rs");
82103
println!("cargo:rustc-link-search=native={}", out_dir.display());
83-
println!("cargo:rustc-link-lib=static=kernel_bin-{}", kernel_file_name);
104+
println!(
105+
"cargo:rustc-link-lib=static=kernel_bin-{}",
106+
kernel_file_name
107+
);
84108
}

src/bootinfo/mod.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,11 @@ impl BootInfo {
4949
/// Create a new boot information structure. This function is only for internal purposes.
5050
#[allow(unused_variables)]
5151
#[doc(hidden)]
52-
pub fn new(memory_map: MemoryMap, recursive_page_table_addr: u64, physical_memory_offset: u64) -> Self {
52+
pub fn new(
53+
memory_map: MemoryMap,
54+
recursive_page_table_addr: u64,
55+
physical_memory_offset: u64,
56+
) -> Self {
5357
BootInfo {
5458
memory_map,
5559
#[cfg(feature = "recursive_page_table")]

src/main.rs

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ use core::{mem, slice};
1616
use fixedvec::alloc_stack;
1717
use usize_conversions::usize_from;
1818
use x86_64::structures::paging::{Mapper, RecursivePageTable};
19-
use x86_64::structures::paging::{Page, PageTableFlags, PhysFrame, PhysFrameRange, Size4KiB,
20-
Size2MiB};
19+
use x86_64::structures::paging::{
20+
Page, PageTableFlags, PhysFrame, PhysFrameRange, Size2MiB, Size4KiB,
21+
};
2122
use x86_64::ux::u9;
2223
use x86_64::{PhysAddr, VirtAddr};
2324

@@ -158,7 +159,8 @@ fn load_elf(
158159
recursive_index,
159160
recursive_index,
160161
recursive_index,
161-
).start_address();
162+
)
163+
.start_address();
162164
let page_table = unsafe { &mut *(recursive_page_table_addr.as_mut_ptr()) };
163165
let mut rec_page_table =
164166
RecursivePageTable::new(page_table).expect("recursive page table creation failed");
@@ -260,7 +262,11 @@ fn load_elf(
260262
}
261263

262264
// Construct boot info structure.
263-
let mut boot_info = BootInfo::new(memory_map, recursive_page_table_addr.as_u64(), PHYSICAL_MEMORY_OFFSET);
265+
let mut boot_info = BootInfo::new(
266+
memory_map,
267+
recursive_page_table_addr.as_u64(),
268+
PHYSICAL_MEMORY_OFFSET,
269+
);
264270
boot_info.memory_map.sort();
265271

266272
// Write boot info to boot info page.
@@ -273,7 +279,9 @@ fn load_elf(
273279
if cfg!(not(feature = "recursive_page_table")) {
274280
// unmap recursive entry
275281
rec_page_table
276-
.unmap(Page::<Size4KiB>::containing_address(recursive_page_table_addr))
282+
.unmap(Page::<Size4KiB>::containing_address(
283+
recursive_page_table_addr,
284+
))
277285
.expect("error deallocating recursive entry")
278286
.1
279287
.flush();

0 commit comments

Comments
 (0)