From 08bb5a9a80410d8ec6403f2ae1a63bcab7b3602b Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sat, 9 Mar 2024 18:35:47 +0100 Subject: [PATCH 1/2] ci: Cross tests - run numeric as release, use s390x Somehow, these take 30m on powerpc, which is too slow (much slower than anything else.) Try to use s390x instead and run numeric tests in release mode. --- .github/workflows/ci.yaml | 2 +- scripts/cross-tests.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c49a85a38..092700611 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -54,7 +54,7 @@ jobs: matrix: include: - rust: stable - target: powerpc-unknown-linux-gnu + target: s390x-unknown-linux-gnu - rust: stable target: i686-unknown-linux-gnu diff --git a/scripts/cross-tests.sh b/scripts/cross-tests.sh index 7473a72fa..dc27058f8 100755 --- a/scripts/cross-tests.sh +++ b/scripts/cross-tests.sh @@ -11,4 +11,4 @@ cross build -v --features="$FEATURES" --target=$TARGET cross test -v --no-fail-fast --features="$FEATURES" --target=$TARGET cross test -v --no-fail-fast --target=$TARGET --manifest-path=ndarray-rand/Cargo.toml --features quickcheck cross test -v --no-fail-fast --target=$TARGET --manifest-path=xtest-serialization/Cargo.toml --verbose -cross test -v --no-fail-fast --target=$TARGET --manifest-path=xtest-numeric/Cargo.toml +cross test -v --no-fail-fast --target=$TARGET --manifest-path=xtest-numeric/Cargo.toml --release From 8e41436547afa3b73b128ba9bc08e1aaaf0b14b7 Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sat, 9 Mar 2024 20:21:02 +0100 Subject: [PATCH 2/2] ci: Run regular tests in pr check We want feedback for contributors from the tests, directly on the PR. --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 092700611..df47549c7 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -17,6 +17,7 @@ jobs: matrix: rust: - beta + name: clippy/${{ matrix.rust }} steps: - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@master @@ -26,7 +27,6 @@ jobs: - uses: Swatinem/rust-cache@v2 - run: cargo clippy --features docs tests: - if: ${{ github.event_name == 'merge_group' }} runs-on: ubuntu-latest strategy: matrix: