Skip to content

Commit 01f7505

Browse files
authored
Merge pull request #709 from rust-ndarray/serde-feature
Rename crate feature serde-1 to just serde
2 parents 54e851d + 64513cc commit 01f7505

File tree

5 files changed

+14
-15
lines changed

5 files changed

+14
-15
lines changed

Cargo.toml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ cblas-sys = { version = "0.1.4", optional = true, default-features = false }
4242
blas-src = { version = "0.2.0", optional = true, default-features = false }
4343

4444
matrixmultiply = { version = "0.2.0" }
45-
# Use via the `serde-1` crate feature!
4645
serde = { version = "1.0", optional = true }
4746
rawpointer = { version = "0.2" }
4847

@@ -57,15 +56,15 @@ itertools = { version = "0.8.0", default-features = false, features = ["use_std"
5756
# See README for more instructions
5857
blas = ["cblas-sys", "blas-src"]
5958

60-
# Serde 1.0
59+
# Old name for the serde feature
6160
serde-1 = ["serde"]
6261

6362
# These features are used for testing
6463
test-blas-openblas-sys = ["blas"]
6564
test = ["test-blas-openblas-sys"]
6665

6766
# This feature is used for docs
68-
docs = ["approx", "serde-1", "rayon"]
67+
docs = ["approx", "serde", "rayon"]
6968

7069
[profile.release]
7170
[profile.bench]

README.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ Crate Feature Flags
4747
The following crate feature flags are available. They are configured in
4848
your `Cargo.toml`.
4949

50-
- ``serde-1``
50+
- ``serde``
5151

5252
- Optional, compatible with Rust stable
53-
- Enables serialization support for serde 1.0
53+
- Enables serialization support for serde 1.x
5454

5555
- ``rayon``
5656

serialization-tests/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ publish = false
88
test = false
99

1010
[dependencies]
11-
ndarray = { path = "../", features = ["serde-1"] }
11+
ndarray = { path = "../", features = ["serde"] }
1212

1313
[features]
1414
default = ["ron"]

src/array_serde.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ where
3232
}
3333
}
3434

35-
/// **Requires crate feature `"serde-1"`**
35+
/// **Requires crate feature `"serde"`**
3636
impl<I> Serialize for Dim<I>
3737
where
3838
I: Serialize,
@@ -45,7 +45,7 @@ where
4545
}
4646
}
4747

48-
/// **Requires crate feature `"serde-1"`**
48+
/// **Requires crate feature `"serde"`**
4949
impl<'de, I> Deserialize<'de> for Dim<I>
5050
where
5151
I: Deserialize<'de>,
@@ -58,7 +58,7 @@ where
5858
}
5959
}
6060

61-
/// **Requires crate feature `"serde-1"`**
61+
/// **Requires crate feature `"serde"`**
6262
impl Serialize for IxDyn {
6363
fn serialize<Se>(&self, serializer: Se) -> Result<Se::Ok, Se::Error>
6464
where
@@ -68,7 +68,7 @@ impl Serialize for IxDyn {
6868
}
6969
}
7070

71-
/// **Requires crate feature `"serde-1"`**
71+
/// **Requires crate feature `"serde"`**
7272
impl<'de> Deserialize<'de> for IxDyn {
7373
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
7474
where
@@ -79,7 +79,7 @@ impl<'de> Deserialize<'de> for IxDyn {
7979
}
8080
}
8181

82-
/// **Requires crate feature `"serde-1"`**
82+
/// **Requires crate feature `"serde"`**
8383
impl<A, D, S> Serialize for ArrayBase<S, D>
8484
where
8585
A: Serialize,
@@ -141,7 +141,7 @@ impl<S, Di> ArrayVisitor<S, Di> {
141141

142142
static ARRAY_FIELDS: &[&str] = &["v", "dim", "data"];
143143

144-
/// **Requires crate feature `"serde-1"`**
144+
/// **Requires crate feature `"serde"`**
145145
impl<'de, A, Di, S> Deserialize<'de> for ArrayBase<S, Di>
146146
where
147147
A: Deserialize<'de>,

src/lib.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@
6868
//! The following crate feature flags are available. They are configured in your
6969
//! `Cargo.toml`.
7070
//!
71-
//! - `serde-1`
71+
//! - `serde`
7272
//! - Optional, compatible with Rust stable
73-
//! - Enables serialization support for serde 1.0
73+
//! - Enables serialization support for serde 1.x
7474
//! - `rayon`
7575
//! - Optional, compatible with Rust stable
7676
//! - Enables parallel iterators, parallelized methods and [`par_azip!`].
@@ -135,7 +135,7 @@ mod private;
135135
mod aliases;
136136
#[cfg(feature = "approx")]
137137
mod array_approx;
138-
#[cfg(feature = "serde-1")]
138+
#[cfg(feature = "serde")]
139139
mod array_serde;
140140
mod arrayformat;
141141
mod arraytraits;

0 commit comments

Comments
 (0)