From f362371f00fd83ad46775e8014d092e5923b1538 Mon Sep 17 00:00:00 2001 From: Amanieu d'Antras Date: Tue, 12 Dec 2023 18:52:55 +0000 Subject: [PATCH] Clarify process for submitting a PR without an ACP This should include a clear motivating examples and a discussion of possible alternative APIs. --- src/development/feature-lifecycle.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/development/feature-lifecycle.md b/src/development/feature-lifecycle.md index ce51bce..a517f39 100644 --- a/src/development/feature-lifecycle.md +++ b/src/development/feature-lifecycle.md @@ -25,6 +25,8 @@ You can create an ACP in the `rust-lang/libs-team` repo using [this issue templa Note that an ACP is not strictly required: you can just go ahead and submit a pull request with an implementation of your proposed API, with the risk of wasted effort if the library team ends up rejecting this feature. However do note that this risk is always present even if an ACP is accepted, as the library team can end up rejecting a feature in the later parts of the stabilization process. +Additionally, if you submit a pull request without an ACP, you should include all of the information that would have been in the ACP in the pull request description. In particular this should include clear motivating examples and a discussion of possible alternative APIs. + ## API design exploration Once a feature is deemed suitable for inclusion in the standard library, the exact design should be iterated on to find the best way to express it as a Rust API. This iteration should happen in community forums such as [Rust internals](https://internals.rust-lang.org/) where all members of the community can comment and propose improvements.