Skip to content

Commit c39bd7b

Browse files
KobzolKobzol
committed
Triage 2024 04 16
1 parent 9bad799 commit c39bd7b

File tree

1 file changed

+156
-0
lines changed

1 file changed

+156
-0
lines changed

‎triage/2024-04-16.md

Lines changed: 156 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,156 @@
1+
# 2024-04-16 Triage Log
2+
3+
A quiet week, with slightly more improvements than regressions.
4+
There were a few noise spikes, but other than that nothing too interesting.
5+
6+
Triage done by **@Kobzol**.
7+
Revision
8+
range: [86b603cd..ccfcd950b](https://perf.rust-lang.org/?start=86b603cd792b3f6172ba4f676d7b586c1af7630a&end=ccfcd950b333fed046275dd8d54fe736ca498aa7&absolute=false&stat=instructions%3Au)
9+
10+
**Summary**:
11+
12+
| (instructions:u) | mean | range | count |
13+
|:---------------------------------:|:-----:|:--------------:|:-----:|
14+
| Regressions ❌ <br /> (primary) | 0.5% | [0.3%, 1.4%] | 9 |
15+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 1.1%] | 20 |
16+
| Improvements ✅ <br /> (primary) | -0.6% | [-2.5%, -0.2%] | 41 |
17+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.4%, -0.2%] | 4 |
18+
| All ❌✅ (primary) | -0.4% | [-2.5%, 1.4%] | 50 |
19+
20+
1 Regression, 3 Improvements, 6 Mixed; 5 of them in rollups
21+
62 artifact comparisons made in total
22+
23+
#### Regressions
24+
25+
Implement syntax for `impl Trait` to specify its captures
26+
explicitly (`feature(precise_capturing)`) [#123468](https://github.com/rust-lang/rust/pull/123468) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ccfcd950b333fed046275dd8d54fe736ca498aa7&end=26e6a2fdaa9443dfe37c77489bd4122119e3c900&stat=instructions:u)
27+
28+
| (instructions:u) | mean | range | count |
29+
|:---------------------------------:|:----:|:------------:|:-----:|
30+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 5 |
31+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
32+
| Improvements ✅ <br /> (primary) | - | - | 0 |
33+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
34+
| All ❌✅ (primary) | 0.2% | [0.2%, 0.2%] | 5 |
35+
36+
* A tiny regression on a stress test, introduced by a new feature.
37+
* Marked as triaged.
38+
39+
#### Improvements
40+
41+
Remove my `scalar_copy_backend_type` optimization
42+
attempt [#123185](https://github.com/rust-lang/rust/pull/123185) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5974fe87c4d711949caa64fc1e8366685c8fc190&end=c2239bca5b89a8d3573cc0fc0f2fa65c50edb79c&stat=instructions:u)
43+
44+
| (instructions:u) | mean | range | count |
45+
|:---------------------------------:|:-----:|:--------------:|:-----:|
46+
| Regressions ❌ <br /> (primary) | - | - | 0 |
47+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
48+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.7%, -0.7%] | 4 |
49+
| Improvements ✅ <br /> (secondary) | -2.0% | [-2.7%, -1.2%] | 2 |
50+
| All ❌✅ (primary) | -0.7% | [-0.7%, -0.7%] | 4 |
51+
52+
Rollup of 8 pull
53+
requests [#123823](https://github.com/rust-lang/rust/pull/123823) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=616a8f85f153033d798b583c0ad0431924a738b0&end=a07f3eb43acc5df851e15176c7081a900a30a4d7&stat=instructions:u)
54+
55+
| (instructions:u) | mean | range | count |
56+
|:---------------------------------:|:-----:|:--------------:|:-----:|
57+
| Regressions ❌ <br /> (primary) | - | - | 0 |
58+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
59+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.1%, -0.2%] | 20 |
60+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
61+
| All ❌✅ (primary) | -0.4% | [-1.1%, -0.2%] | 20 |
62+
63+
Rollup of 4 pull
64+
requests [#123982](https://github.com/rust-lang/rust/pull/123982) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=99d0186b1d0547eae913eff04be272c9d348b9b8&end=3493a56529b3f972205f2cdda920132deef4b475&stat=instructions:u)
65+
66+
| (instructions:u) | mean | range | count |
67+
|:---------------------------------:|:-----:|:--------------:|:-----:|
68+
| Regressions ❌ <br /> (primary) | - | - | 0 |
69+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
70+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.8%, -0.3%] | 8 |
71+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
72+
| All ❌✅ (primary) | -0.6% | [-0.8%, -0.3%] | 8 |
73+
74+
#### Mixed
75+
76+
Only collect mono items from reachable
77+
blocks [#123272](https://github.com/rust-lang/rust/pull/123272) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=86b603cd792b3f6172ba4f676d7b586c1af7630a&end=bb78dba64ca4158ef2f3488d0d41a82c75a504f2&stat=instructions:u)
78+
79+
| (instructions:u) | mean | range | count |
80+
|:---------------------------------:|:-----:|:--------------:|:-----:|
81+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 1.5%] | 8 |
82+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
83+
| Improvements ✅ <br /> (primary) | -0.8% | [-1.5%, -0.3%] | 6 |
84+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
85+
| All ❌✅ (primary) | -0.1% | [-1.5%, 1.5%] | 14 |
86+
87+
* Fixed an important bug, and results were mixed anyway.
88+
89+
Rollup of 7 pull
90+
requests [#123725](https://github.com/rust-lang/rust/pull/123725) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e908cfd125ae9d98550edb9ffd8d7eae4be601ac&end=5974fe87c4d711949caa64fc1e8366685c8fc190&stat=instructions:u)
91+
92+
| (instructions:u) | mean | range | count |
93+
|:---------------------------------:|:-----:|:--------------:|:-----:|
94+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 2 |
95+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.2%, 2.6%] | 7 |
96+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.6%, -0.2%] | 2 |
97+
| Improvements ✅ <br /> (secondary) | -0.6% | [-0.6%, -0.6%] | 1 |
98+
| All ❌✅ (primary) | -0.1% | [-0.6%, 0.2%] | 4 |
99+
100+
* The largest regressions were noise, the rest was mixed.
101+
* Marked as triaged.
102+
103+
Rollup of 8 pull
104+
requests [#123762](https://github.com/rust-lang/rust/pull/123762) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aa067fb984d36462548bb785da221bfaf38253f0&end=4435924bb62cda0131e38dd5d2bba36f9616039f&stat=instructions:u)
105+
106+
| (instructions:u) | mean | range | count |
107+
|:---------------------------------:|:-----:|:--------------:|:-----:|
108+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.5%] | 2 |
109+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 1.7%] | 9 |
110+
| Improvements ✅ <br /> (primary) | - | - | 0 |
111+
| Improvements ✅ <br /> (secondary) | -2.8% | [-4.2%, -1.4%] | 2 |
112+
| All ❌✅ (primary) | 0.4% | [0.2%, 0.5%] | 2 |
113+
114+
* The largest regression on the `coercions` benchmark is noise.
115+
* The rest were small regressions on `doc` benchmarks.
116+
* Marked as triaged.
117+
118+
Rollup of 4 pull
119+
requests [#123884](https://github.com/rust-lang/rust/pull/123884) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6cfd80942e4599a6e429e8a2aa27af38f5987aa0&end=59c38c06049fc3fba98bb046701eb2ab1777d998&stat=instructions:u)
120+
121+
| (instructions:u) | mean | range | count |
122+
|:---------------------------------:|:-----:|:--------------:|:-----:|
123+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 1 |
124+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
125+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.0%, -1.0%] | 1 |
126+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 6 |
127+
| All ❌✅ (primary) | -0.3% | [-1.0%, 0.4%] | 2 |
128+
129+
* The single regression was immediately reverted, the rest were small improvements.
130+
* Marked as triaged.
131+
132+
Re-enable `has_thread_local` for
133+
i686-msvc [#123257](https://github.com/rust-lang/rust/pull/123257) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=59c38c06049fc3fba98bb046701eb2ab1777d998&end=f96442b4482fef6a50b65f2284bcfb8921320183&stat=instructions:u)
134+
135+
| (instructions:u) | mean | range | count |
136+
|:---------------------------------:|:-----:|:--------------:|:-----:|
137+
| Regressions ❌ <br /> (primary) | - | - | 0 |
138+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.4%] | 6 |
139+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
140+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
141+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
142+
143+
* This has to be noise, since the PR did not modify x64 Linux.
144+
145+
Get rid of `USIZE_MARKER` in formatting
146+
infrastructure [#123819](https://github.com/rust-lang/rust/pull/123819) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0bf471f339837af930ec90ef5e1e9cb232e99f29&end=7ab5eb8fe7aee35aea8ed4aed8c34f6abd988cc5&stat=instructions:u)
147+
148+
| (instructions:u) | mean | range | count |
149+
|:---------------------------------:|:-----:|:--------------:|:-----:|
150+
| Regressions ❌ <br /> (primary) | 0.6% | [0.4%, 0.9%] | 2 |
151+
| Regressions ❌ <br /> (secondary) | 1.5% | [1.5%, 1.5%] | 1 |
152+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.6%, -0.3%] | 5 |
153+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
154+
| All ❌✅ (primary) | -0.1% | [-0.6%, 0.9%] | 7 |
155+
156+
* More improvements than regressions.

0 commit comments

Comments
 (0)