From 067003eabaf07a9af5c8f47efa9f13202eedbe54 Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Sun, 15 Jan 2023 21:18:38 +0200 Subject: [PATCH 1/3] rustc_typeck exists no more --- src/type-checking.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/type-checking.md b/src/type-checking.md index 08f15e30b..d9731649a 100644 --- a/src/type-checking.md +++ b/src/type-checking.md @@ -1,10 +1,10 @@ # Type checking -The [`rustc_typeck`][typeck] crate contains the source for "type collection" +The [`hir_analysis`] crate contains the source for "type collection" and "type checking", as well as a few other bits of related functionality. (It draws heavily on the [type inference] and [trait solving].) -[typeck]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/index.html +[`hir_analysis`]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/index.html [type inference]: ./type-inference.md [trait solving]: ./traits/resolution.md From 156c4e6a0f4963b9e5d66b9c879699f2f0f25e15 Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Tue, 17 Jan 2023 16:46:58 +0200 Subject: [PATCH 2/3] accept review suggestion Co-authored-by: lcnr --- src/type-checking.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/type-checking.md b/src/type-checking.md index d9731649a..2f8e8fafd 100644 --- a/src/type-checking.md +++ b/src/type-checking.md @@ -1,8 +1,6 @@ # Type checking -The [`hir_analysis`] crate contains the source for "type collection" -and "type checking", as well as a few other bits of related functionality. (It -draws heavily on the [type inference] and [trait solving].) +The [`hir_analysis`] crate contains the source for "type collection" as well as a bunch of related functionality. Checking the bodies of functions is implemented in the [`hir_typeck`] crate. (It draws heavily on the [type inference] and [trait solving].) [`hir_analysis`]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/index.html [type inference]: ./type-inference.md From 9b7df3732c81466dafd1097ad430598f309f487b Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Tue, 17 Jan 2023 17:00:54 +0200 Subject: [PATCH 3/3] fix review suggestion --- src/type-checking.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/type-checking.md b/src/type-checking.md index 2f8e8fafd..b60694201 100644 --- a/src/type-checking.md +++ b/src/type-checking.md @@ -1,8 +1,12 @@ # Type checking -The [`hir_analysis`] crate contains the source for "type collection" as well as a bunch of related functionality. Checking the bodies of functions is implemented in the [`hir_typeck`] crate. (It draws heavily on the [type inference] and [trait solving].) +The [`hir_analysis`] crate contains the source for "type collection" as well +as a bunch of related functionality. +Checking the bodies of functions is implemented in the [`hir_typeck`] crate. +These crates draw heavily on the [type inference] and [trait solving]. [`hir_analysis`]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/index.html +[`hir_typeck`]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_typeck/index.html [type inference]: ./type-inference.md [trait solving]: ./traits/resolution.md