From bef89e34302e26965f70c568d9e195b496bbe859 Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Sat, 27 Aug 2022 05:29:05 +0200 Subject: [PATCH 1/3] updating-llvm: keep a calm tone Also, keep it trimmed... if a formal policy is adopted, this text can be updated to indicate so. --- src/backend/updating-llvm.md | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/src/backend/updating-llvm.md b/src/backend/updating-llvm.md index 81ebbbb40..3d1ab1dd4 100644 --- a/src/backend/updating-llvm.md +++ b/src/backend/updating-llvm.md @@ -2,20 +2,15 @@ -The Rust compiler uses LLVM as its primary codegen backend today, and naturally -we want to at least occasionally update this dependency! Currently we do not -have a strict policy about when to update LLVM or what it can be updated to, but -a few guidelines are applied: - -* We try to always support the latest released version of LLVM -* We try to support the "last few" versions of LLVM (how many is changing over - time) -* We allow moving to arbitrary commits during development. -* Strongly prefer to upstream all patches to LLVM before including them in - rustc. - -This policy may change over time (or may actually start to exist as a formal -policy!), but for now these are rough guidelines! + +There is no formal policy about when to update LLVM or what it can be updated to, +but a few guidelines are applied: + +* We try to always support the latest released version +* We try to support the last few versions of LLVM + (and the number changes over time) +* We allow moving to arbitrary commits during development +* We Strongly prefer to upstream all patches to LLVM before including them in rustc ## Why update LLVM? From 488fccb8f8185e407e796cc44305498a4e4c62a8 Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Sun, 20 Nov 2022 07:50:37 +0200 Subject: [PATCH 2/3] accept review suggestion Co-authored-by: Yuki Okushi --- src/backend/updating-llvm.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/updating-llvm.md b/src/backend/updating-llvm.md index 3d1ab1dd4..86b6d2cd4 100644 --- a/src/backend/updating-llvm.md +++ b/src/backend/updating-llvm.md @@ -10,7 +10,7 @@ but a few guidelines are applied: * We try to support the last few versions of LLVM (and the number changes over time) * We allow moving to arbitrary commits during development -* We Strongly prefer to upstream all patches to LLVM before including them in rustc +* We strongly prefer to upstream all patches to LLVM before including them in rustc ## Why update LLVM? From f965b679d375fdad42432984435bacc110f2354d Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Sun, 20 Nov 2022 07:56:35 +0200 Subject: [PATCH 3/3] address review comment https://github.com/rust-lang/rustc-dev-guide/pull/1449/files#r959387043 --- src/backend/updating-llvm.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/updating-llvm.md b/src/backend/updating-llvm.md index 86b6d2cd4..d644c15df 100644 --- a/src/backend/updating-llvm.md +++ b/src/backend/updating-llvm.md @@ -7,7 +7,7 @@ There is no formal policy about when to update LLVM or what it can be updated to but a few guidelines are applied: * We try to always support the latest released version -* We try to support the last few versions of LLVM +* We try to support the last few versions (and the number changes over time) * We allow moving to arbitrary commits during development * We strongly prefer to upstream all patches to LLVM before including them in rustc