Skip to content

Commit 5ff627e

Browse files
mark-i-mcamelid
andcommitted
Apply suggestions from code review
Co-authored-by: Camelid <37223377+camelid@users.noreply.github.com>
1 parent 5784b6c commit 5ff627e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/getting-started.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ the following settings:
132132
- `incremental = true`: enables incremental compilation of the compiler itself.
133133
This is turned off by default because it's technically unsound. Sometimes
134134
this will cause weird crashes, but it can really speed things up.
135-
- `llvm-config`: enable building with system LLVM. [See this chapter][sysllvm]
135+
- `llvm-config`: enables building with system LLVM. [See this chapter][sysllvm]
136136
for more info. This avoids building LLVM, which can take a while.
137137

138138
[sysllvm]: ./building/suggested.html#building-with-system-llvm
@@ -274,7 +274,7 @@ highlights, but there are a lot more details, which we will link to below.
274274

275275
### Code Review
276276

277-
When you open a PR on the `rust-lang/rust` repo, a bot called `@highfive` will
277+
When you open a PR on the `rust-lang/rust` repo, a bot called `@rust-highfive` will
278278
automatically assign a reviewer to the PR. The reviewer is the person that will
279279
approve the PR to be tested and merged. If you want a specific reviewer (e.g. a
280280
team member you've been working with), you can specifically request them by
@@ -334,7 +334,7 @@ The feature then needs to be implemented behind a feature gate, which prevents
334334
it from being accidentally used.
335335

336336
Finally, somebody may propose stabilizing the feature in an upcoming version of
337-
Rust. This requires an FCP (see below) to get the approval of the relevant teams.
337+
Rust. This requires a Final Comment Period (see below) to get the approval of the relevant teams.
338338

339339
After that, the feature gate can be removed and the feature turned on for all users.
340340

@@ -400,6 +400,6 @@ master.
400400

401401
- This guide: talks about how `rustc` works
402402
- [The t-compiler zulip][z]
403-
- [The compiler's documentation (rustdocs)](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/)
403+
- [The compiler's documentation (rustdocs)](https://doc.rust-lang.org/nightly/nightly-rustc/)
404404

405405
TODO: am I missing any?

0 commit comments

Comments
 (0)