diff --git a/compiler/rustc_index/src/bit_set.rs b/compiler/rustc_index/src/bit_set.rs index 33a8d6c11ff99..059755a743b66 100644 --- a/compiler/rustc_index/src/bit_set.rs +++ b/compiler/rustc_index/src/bit_set.rs @@ -479,6 +479,11 @@ impl ChunkedBitSet { } } + #[inline] + pub fn iter(&self) -> ChunkedBitIter<'_, T> { + ChunkedBitIter::new(self) + } + /// Insert `elem`. Returns whether the set has changed. pub fn insert(&mut self, elem: T) -> bool { assert!(elem.index() < self.domain_size); @@ -697,6 +702,49 @@ impl Clone for ChunkedBitSet { } } +pub struct ChunkedBitIter<'a, T: Idx> { + index: usize, + bitset: &'a ChunkedBitSet, +} + +impl<'a, T: Idx> ChunkedBitIter<'a, T> { + #[inline] + fn new(bitset: &'a ChunkedBitSet) -> ChunkedBitIter<'a, T> { + ChunkedBitIter { index: 0, bitset } + } +} + +impl<'a, T: Idx> Iterator for ChunkedBitIter<'a, T> { + type Item = T; + fn next(&mut self) -> Option { + while self.index < self.bitset.domain_size() { + let elem = T::new(self.index); + let chunk = &self.bitset.chunks[chunk_index(elem)]; + match &chunk { + Zeros(chunk_domain_size) => { + self.index += *chunk_domain_size as usize; + } + Ones(_chunk_domain_size) => { + self.index += 1; + return Some(elem); + } + Mixed(_chunk_domain_size, _, words) => loop { + let elem = T::new(self.index); + self.index += 1; + let (word_index, mask) = chunk_word_index_and_mask(elem); + if (words[word_index] & mask) != 0 { + return Some(elem); + } + if self.index % CHUNK_BITS == 0 { + break; + } + }, + } + } + None + } +} + impl Chunk { #[cfg(test)] fn assert_valid(&self) { diff --git a/compiler/rustc_index/src/bit_set/tests.rs b/compiler/rustc_index/src/bit_set/tests.rs index eec7dab5189a6..cfc891e97a32b 100644 --- a/compiler/rustc_index/src/bit_set/tests.rs +++ b/compiler/rustc_index/src/bit_set/tests.rs @@ -342,6 +342,40 @@ fn chunked_bitset() { b10000b.assert_valid(); } +#[test] +fn chunked_bitset_iter() { + fn with_elements(elements: &[usize], domain_size: usize) -> ChunkedBitSet { + let mut s = ChunkedBitSet::new_empty(domain_size); + for &e in elements { + s.insert(e); + } + s + } + + // Empty + let vec: Vec = Vec::new(); + let bit = with_elements(&vec, 9000); + assert_eq!(vec, bit.iter().collect::>()); + + // Filled + let n = 10000; + let vec: Vec = (0..n).collect(); + let bit = with_elements(&vec, n); + assert_eq!(vec, bit.iter().collect::>()); + + // Filled with trailing zeros + let n = 10000; + let vec: Vec = (0..n).collect(); + let bit = with_elements(&vec, 2 * n); + assert_eq!(vec, bit.iter().collect::>()); + + // Mixed + let n = 12345; + let vec: Vec = vec![0, 1, 2, 2010, 2047, 2099, 6000, 6002, 6004]; + let bit = with_elements(&vec, n); + assert_eq!(vec, bit.iter().collect::>()); +} + #[test] fn grow() { let mut set: GrowableBitSet = GrowableBitSet::with_capacity(65); diff --git a/compiler/rustc_mir_dataflow/src/framework/fmt.rs b/compiler/rustc_mir_dataflow/src/framework/fmt.rs index 99735673f4d58..209e6f7ac9fe4 100644 --- a/compiler/rustc_mir_dataflow/src/framework/fmt.rs +++ b/compiler/rustc_mir_dataflow/src/framework/fmt.rs @@ -93,57 +93,83 @@ where }; } - let mut first = true; - for idx in set_in_self.iter() { - let delim = if first { - "\u{001f}+" - } else if f.alternate() { - "\n\u{001f}+" - } else { - ", " - }; + fmt_diff(&set_in_self, &cleared_in_self, ctxt, f) + } +} - write!(f, "{}", delim)?; - idx.fmt_with(ctxt, f)?; - first = false; - } +impl DebugWithContext for ChunkedBitSet +where + T: Idx + DebugWithContext, +{ + fn fmt_with(&self, ctxt: &C, f: &mut fmt::Formatter<'_>) -> fmt::Result { + f.debug_set().entries(self.iter().map(|i| DebugWithAdapter { this: i, ctxt })).finish() + } - if !f.alternate() { - first = true; - if !set_in_self.is_empty() && !cleared_in_self.is_empty() { - write!(f, "\t")?; - } - } + fn fmt_diff_with(&self, old: &Self, ctxt: &C, f: &mut fmt::Formatter<'_>) -> fmt::Result { + let size = self.domain_size(); + assert_eq!(size, old.domain_size()); - for idx in cleared_in_self.iter() { - let delim = if first { - "\u{001f}-" - } else if f.alternate() { - "\n\u{001f}-" - } else { - ", " - }; + let mut set_in_self = HybridBitSet::new_empty(size); + let mut cleared_in_self = HybridBitSet::new_empty(size); - write!(f, "{}", delim)?; - idx.fmt_with(ctxt, f)?; - first = false; + for i in (0..size).map(T::new) { + match (self.contains(i), old.contains(i)) { + (true, false) => set_in_self.insert(i), + (false, true) => cleared_in_self.insert(i), + _ => continue, + }; } - Ok(()) + fmt_diff(&set_in_self, &cleared_in_self, ctxt, f) } } -impl DebugWithContext for ChunkedBitSet +fn fmt_diff( + inserted: &HybridBitSet, + removed: &HybridBitSet, + ctxt: &C, + f: &mut fmt::Formatter<'_>, +) -> fmt::Result where T: Idx + DebugWithContext, { - fn fmt_with(&self, _ctxt: &C, _f: &mut fmt::Formatter<'_>) -> fmt::Result { - unimplemented!("implement when/if needed"); + let mut first = true; + for idx in inserted.iter() { + let delim = if first { + "\u{001f}+" + } else if f.alternate() { + "\n\u{001f}+" + } else { + ", " + }; + + write!(f, "{}", delim)?; + idx.fmt_with(ctxt, f)?; + first = false; + } + + if !f.alternate() { + first = true; + if !inserted.is_empty() && !removed.is_empty() { + write!(f, "\t")?; + } } - fn fmt_diff_with(&self, _old: &Self, _ctxt: &C, _f: &mut fmt::Formatter<'_>) -> fmt::Result { - unimplemented!("implement when/if needed"); + for idx in removed.iter() { + let delim = if first { + "\u{001f}-" + } else if f.alternate() { + "\n\u{001f}-" + } else { + ", " + }; + + write!(f, "{}", delim)?; + idx.fmt_with(ctxt, f)?; + first = false; } + + Ok(()) } impl DebugWithContext for &'_ T