-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Use AttrVec
for Arm
, FieldDef
, and Variant
#86385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some changes occurred in src/tools/rustfmt. |
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rustfmt changes are good so providing approval accordingly
fwiw, the other changes lgtm to me as well and agree with thinking that attrs would be more common on Item
and Crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, seems fairly likely to be an perf improvement, but I'll do a perf run anyway to double check. r=me when perf results are good.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 4f8e0eb with merge a6b8035f4e90621eeba98861987b82318abcb25c... |
☀️ Try build successful - checks-actions |
Queued a6b8035f4e90621eeba98861987b82318abcb25c with parent 0ef2b4a, future comparison URL. |
Finished benchmarking try commit (a6b8035f4e90621eeba98861987b82318abcb25c): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Small wins up to ~0.5%, there're 0.2% regressions but they can be noises or acceptable, I'm going to land. @bors r=davidtwco |
📌 Commit 4f8e0eb has been approved by |
☀️ Test successful - checks-actions |
Uses
AttrVec
forArm
,FieldDef
, andVariant
, i.e., where the size of the vector can be empty often.Skips
Crate
andItem
because I think they may have the attributes on common cases and need more work outside ofrustc_ast
(e.g. rustc_expand needs a lot of tweaks). But if it's reasonable to change, I'm happy to do so.Fixes #77662