Skip to content

Removed two unused variables in os.rs #51555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2018
Merged

Removed two unused variables in os.rs #51555

merged 1 commit into from
Jun 17, 2018

Conversation

ccesare
Copy link
Contributor

@ccesare ccesare commented Jun 14, 2018

Issue #51419 suggested removing two unused variables in libstd/sys/redox/os.rs. This PR implements that change.

It compiles for me locally, but I haven't run any other tests.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2018
@kennytm
Copy link
Member

kennytm commented Jun 17, 2018

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 17, 2018

📌 Commit 8f0909c has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2018
@bors
Copy link
Collaborator

bors commented Jun 17, 2018

⌛ Testing commit 8f0909c with merge 2b973e6...

bors added a commit that referenced this pull request Jun 17, 2018
@bors
Auto merge of #51555 - ccesare:remove_unused_variables_redox_os, r=ke…
2b973e6 
…nnytm

Removed two unused variables in os.rs

Issue #51419 suggested removing two unused variables in `libstd/sys/redox/os.rs`. This PR implements that change.

It compiles for me locally, but I haven't run any other tests.
@bors
Copy link
Collaborator

bors commented Jun 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 2b973e6 to master...

@bors bors merged commit 8f0909c into rust-lang:master Jun 17, 2018
@nodakai
Copy link
Contributor

nodakai commented Jun 22, 2018

Did anybody confirm a getenv() call on Redox will not be cluttered by a concurrent setenv() call from another thread unlike *nix? Maybe this RW-mutex within the filesystem layer assures that? https://github.com/redox-os/kernel/blob/master/src/scheme/env.rs#L114

@varkor varkor mentioned this pull request Jun 23, 2018
Closed
@ccesare ccesare deleted the remove_unused_variables_redox_os branch August 7, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ccesare @rust-highfive @kennytm @bors @nodakai @aturon