-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Update README.md #51539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #51539
Conversation
Corrected the grammar of the document.
README.md
Outdated
you have a more recent version installed the build system doesn't understand | ||
then you may need to force rustbuild to use an older version. This can be done | ||
then you may need to force rust build to use an older version. This can be done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rustbuild is correct, it's the name of the build tool that bootstraps the compiler and builds everything with Cargo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonas-schievink Thanks for correction. I have reverted it.
README.md
Outdated
@@ -159,7 +159,7 @@ $ ./configure | |||
$ make && sudo make install | |||
``` | |||
|
|||
When using the configure script, the generated `config.mk` file may override the | |||
When using the configure script, the generated `config.mk` the file may override the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an extra the
- it was correct before the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonas-schievink Yes Correct. I have reverted it.
README.md
Outdated
development). As such, source builds require a connection to the Internet, to | ||
fetch snapshots, and an OS that can execute the available snapshot binaries. | ||
fetch snapshots and an OS that can execute the available snapshot binaries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an Oxford comma, which is also correct and makes this more readable, imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonas-schievink Thanks, I have reverted it.
@bors r+ rollup |
📌 Commit b0a5555 has been approved by |
Update README.md Corrected the grammar of the document.
☀️ Test successful - status-appveyor, status-travis |
Corrected the grammar of the document.