Skip to content

Update README.md #51539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Jun 13, 2018
Merged

Update README.md #51539

merged 2 commits into from Jun 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 13, 2018

Corrected the grammar of the document.

Corrected the grammar of the document.
README.md Outdated
you have a more recent version installed the build system doesn't understand
then you may need to force rustbuild to use an older version. This can be done
then you may need to force rust build to use an older version. This can be done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustbuild is correct, it's the name of the build tool that bootstraps the compiler and builds everything with Cargo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonas-schievink Thanks for correction. I have reverted it.

README.md Outdated
@@ -159,7 +159,7 @@ $ ./configure
$ make && sudo make install
```

When using the configure script, the generated `config.mk` file may override the
When using the configure script, the generated `config.mk` the file may override the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an extra the - it was correct before the change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonas-schievink Yes Correct. I have reverted it.

README.md Outdated
development). As such, source builds require a connection to the Internet, to
fetch snapshots, and an OS that can execute the available snapshot binaries.
fetch snapshots and an OS that can execute the available snapshot binaries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an Oxford comma, which is also correct and makes this more readable, imo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonas-schievink Thanks, I have reverted it.

@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 13, 2018

📌 Commit b0a5555 has been approved by estebank

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 13, 2018
bors added a commit that referenced this pull request Jun 13, 2018
Update README.md

Corrected the grammar of the document.
@bors
Copy link
Collaborator

bors commented Jun 13, 2018

⌛ Testing commit b0a5555 with merge e12733b...

@bors
Copy link
Collaborator

bors commented Jun 13, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing e12733b to master...

@bors bors merged commit b0a5555 into rust-lang:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants