From b5e5d96647a92e03d480c3cb1e0fad3f31723c76 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Fri, 9 Dec 2022 21:04:13 +0100 Subject: [PATCH 1/2] Fix alignment of badges --- src/librustdoc/html/static/css/rustdoc.css | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/librustdoc/html/static/css/rustdoc.css b/src/librustdoc/html/static/css/rustdoc.css index 91162ca4892ca..1106278b943c8 100644 --- a/src/librustdoc/html/static/css/rustdoc.css +++ b/src/librustdoc/html/static/css/rustdoc.css @@ -766,6 +766,9 @@ table, .item-left { padding-right: 1.25rem; } +.item-left > a, .item-left > span { + vertical-align: middle; +} .search-results-title { margin-top: 0; From a96ccbe5f7044aad209049cba338d29db1b5c286 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Fri, 9 Dec 2022 21:04:27 +0100 Subject: [PATCH 2/2] Add GUI test for badge alignment --- src/test/rustdoc-gui/stab-badge.goml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/test/rustdoc-gui/stab-badge.goml b/src/test/rustdoc-gui/stab-badge.goml index aaed8440a40bd..f395b778fe6c4 100644 --- a/src/test/rustdoc-gui/stab-badge.goml +++ b/src/test/rustdoc-gui/stab-badge.goml @@ -1,6 +1,21 @@ // All stability badges should have rounded corners and colored backgrounds. goto: "file://" + |DOC_PATH| + "/test_docs/index.html" show-text: true + +// Checking the alignment of the badges text with the item name. +assert-css: ( + "//*[@class='item-table']//*[@class='item-left module-item']/*[@class='stab deprecated']", + {"padding-top": "2px"}, +) +assert-position: ( + "//*[@class='item-table']//*[@class='item-left module-item']/*[@class='stab deprecated']", + {"y": 1892}, +) +assert-position: ( + "//*[@class='item-table']//*[@class='item-left module-item']/*[@class='stab deprecated']/preceding-sibling::a", + {"y": 1894}, // 1892 + 2 because of padding +) + define-function: ( "check-badge", (theme, background, color),