Closed
Description
In PR #66329 we created a MIR optimization pass that optimizes away unreachable basic blocks, i.e., basic blocks whose terminator kind is Unreachable.
Running on rustc_perf
we observed improvement in all benchmarks except unicode-normalization (avg ~3%) and deeply-nested-opt (avg: 740644.6%). A more complete analysis of the compile times can be found here and here. As explained by @bjorn3, for deeply-nested-opt
the LLVM related queries are the ones slowing down, not anything inside rustc.
Until the root cause of the increase in compile times is found and fixed, we have made the optimization available only as a level 3 optimization.
Metadata
Metadata
Assignees
Labels
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.htmlArea: MIR optimizationsIssue: Problems and improvements with respect to compile times.Relevant to the compiler team, which will review and decide on the PR/issue.