-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix trait implementations sort order #137428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @compiler-errors. Use |
The job Click to see the possible cause of the failure (guessed by this bot)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sort by args.len()
then the trait ref rendered as a string, otherwise you'll reintroduce some instability in trait ordering when you have two trait refs with the same number of args but different names
Using args.len() along with trait ref string doesn't give the expected result and goes back to previous state. Logic needs to be revisited again. Closing the PR for now. |
Fixes #135098