Skip to content

replace-version-placeholder should not recurse into the rustc-dev-guide #102014

Closed
@pietroalbini

Description

@pietroalbini

Right now, running ./x run replace-version-placeholder causes among other things this unwanted diff:

diff --git a/src/doc/rustc-dev-guide/src/stabilization_guide.md b/src/doc/rustc-dev-guide/src/stabilization_guide.md
index 0ac1929..188faa8 100644
--- a/src/doc/rustc-dev-guide/src/stabilization_guide.md
+++ b/src/doc/rustc-dev-guide/src/stabilization_guide.md
@@ -109,7 +109,7 @@ to stabilize, something like (this example is taken from
 
 ```rust,ignore
 // pub(restricted) visibilities (RFC 1422)
-(active, pub_restricted, "CURRENT_RUSTC_VERSION", Some(32409)),
+(active, pub_restricted, "1.65.0", Some(32409)),
 ```
 
 The above line should be moved down to the area for "accepted"
@@ -118,13 +118,13 @@ When it is done, it should look like:
 
 ```rust,ignore
 // pub(restricted) visibilities (RFC 1422)
-(accepted, pub_restricted, "CURRENT_RUSTC_VERSION", Some(32409)),
+(accepted, pub_restricted, "1.65.0", Some(32409)),
 // note that we changed this
 ```
 
 (Even though you will encounter version numbers in the file of past changes,
 you should not put the rustc version you expect your stabilization to happen in,
-but instead `CURRENT_RUSTC_VERSION`)
+but instead `1.65.0`)
 
 ### Removing existing uses of the feature-gate

We should change it not to recurse into submodules, or at least that submodule.

cc @Mark-Simulacrum @est31

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions