Skip to content

Commit f38b83b

Browse files
committed
Avoid unnecessary mutability for UnusedResults.
1 parent 2a37f7f commit f38b83b

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/librustc_lint/builtin.rs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -741,23 +741,24 @@ impl LintPass for UnusedResults {
741741
}
742742

743743
let t = ty::expr_ty(cx.tcx, expr);
744-
let mut warned = false;
745-
match t.sty {
744+
let warned = match t.sty {
746745
ty::ty_tup(ref tys) if tys.is_empty() => return,
747746
ty::ty_bool => return,
748747
ty::ty_struct(did, _) |
749748
ty::ty_enum(did, _) => {
750749
if ast_util::is_local(did) {
751750
if let ast_map::NodeItem(it) = cx.tcx.map.get(did.node) {
752-
warned |= check_must_use(cx, &it.attrs, s.span);
751+
check_must_use(cx, &it.attrs, s.span)
752+
} else {
753+
false
753754
}
754755
} else {
755756
let attrs = csearch::get_item_attrs(&cx.sess().cstore, did);
756-
warned |= check_must_use(cx, &attrs[..], s.span);
757+
check_must_use(cx, &attrs[..], s.span)
757758
}
758759
}
759-
_ => {}
760-
}
760+
_ => false,
761+
};
761762
if !warned {
762763
cx.span_lint(UNUSED_RESULTS, s.span, "unused result");
763764
}

0 commit comments

Comments
 (0)