lint ImproperCTypes: changes to pass CI [...]

- make clippy happy about the changes in rust_codegen_llvm
- split a test stderr into 32bit and 64bit
- fix some documentation

Author: niacdoial

compiler/rustc_codegen_llvm/src/llvm/ffi.rs

@@ -1306,7 +1306,8 @@ unsafe extern "C" {
     );
 
     // Instruction builders
-    |wrap pub(crate) fn LLVMCreateBuilderInContext(C: &Context) -> &mut Builder<'_>;
+    |wrap #[allow(clippy::mut_from_ref)]  // FIXME?
+    pub(crate) fn LLVMCreateBuilderInContext(C: &Context) -> &mut Builder<'_>;
     pub(crate) fn LLVMPositionBuilderAtEnd<'a>(Builder: &Builder<'a>, Block: &'a BasicBlock);
     |wrap pub(crate) fn LLVMGetInsertBlock<'a>(Builder_: &Builder<'a>) -> &'a BasicBlock;
     pub(crate) fn LLVMDisposeBuilder<'a>(Builder: &'a mut Builder<'a>);
@@ -2566,7 +2567,8 @@ unsafe extern "C" {
     pub(crate) fn LLVMRustRunRestrictionPass(M: &Module, syms: *const *const c_char, len: size_t);
 
     pub(crate) fn LLVMRustOpenArchive(path: *const c_char) -> Option<&'static mut Archive>;
-    |wrap pub(crate) fn LLVMRustArchiveIteratorNew(AR: &Archive) -> &mut ArchiveIterator<'_>;
+    |wrap #[allow(clippy::mut_from_ref)]  // FIXME?
+    pub(crate) fn LLVMRustArchiveIteratorNew(AR: &Archive) -> &mut ArchiveIterator<'_>;
     pub(crate) fn LLVMRustArchiveIteratorNext<'a>(
         AIR: &ArchiveIterator<'a>,
     ) -> Option<&'a mut ArchiveChild<'a>>;
@@ -2687,7 +2689,8 @@ unsafe extern "C" {
         out_len: &mut usize,
     ) -> *const u8;
 
-    |wrap pub(crate) fn LLVMRustLinkerNew(M: &Module) -> &mut Linker<'_>;
+    |wrap #[allow(clippy::mut_from_ref)]  // FIXME?
+    pub(crate) fn LLVMRustLinkerNew(M: &Module) -> &mut Linker<'_>;
     pub(crate) fn LLVMRustLinkerAdd(
         linker: &Linker<'_>,
         bytecode: *const c_char,

compiler/rustc_lint/src/types/improper_ctypes.rs

@@ -2038,7 +2038,8 @@ declare_lint! {
     /// ### Example
     ///
     /// ```rust
-    /// # #![unsafe(no_mangle)]
+    /// # #[unsafe(no_mangle)]
+    /// # #[used]
     /// static mut PLUGIN_ABI_MIN_VERSION: &'static str = "0.0.5";
     /// ```
     ///

src/tools/clippy/tests/ui/boxed_local.rs

@@ -171,11 +171,11 @@ mod issue_3739 {
 /// Issue #5542
 ///
 /// This shouldn't warn for `boxed_local` as it is intended to called from non-Rust code.
-pub extern "C" fn do_not_warn_me(_c_pointer: Box<String>) -> () {}
+pub extern "C" fn do_not_warn_me(_c_pointer: Option<Box<String>>) -> () {}
 
 #[allow(missing_abi)]
 #[rustfmt::skip] // Forces rustfmt to not add ABI
-pub extern fn do_not_warn_me_no_abi(_c_pointer: Box<String>) -> () {}
+pub extern fn do_not_warn_me_no_abi(_c_pointer: Option<Box<String>>) -> () {}
 
 // Issue #4804 - default implementation in trait
 mod issue4804 {

src/tools/clippy/tests/ui/ptr_arg.rs

@@ -317,6 +317,7 @@ mod issue_9218 {
     }
 }
 
+#[allow(improper_c_fn_definitions)]
 mod issue_11181 {
     extern "C" fn allowed(_v: &Vec<u32>) {}
 

src/tools/clippy/tests/ui/ptr_arg.stderr

@@ -229,13 +229,13 @@ LL |     fn cow_bad_ret_ty_2<'a, 'b>(input: &'a Cow<'a, str>) -> &'b str {
    |                                        ^^^^^^^^^^^^^^^^ help: change this to: `&str`
 
 error: writing `&String` instead of `&str` involves a new object where a slice will do
-  --> tests/ui/ptr_arg.rs:347:17
+  --> tests/ui/ptr_arg.rs:348:17
    |
 LL |     fn good(v1: &String, v2: &String) {
    |                 ^^^^^^^ help: change this to: `&str`
 
 error: writing `&String` instead of `&str` involves a new object where a slice will do
-  --> tests/ui/ptr_arg.rs:347:30
+  --> tests/ui/ptr_arg.rs:348:30
    |
 LL |     fn good(v1: &String, v2: &String) {
    |                              ^^^^^^^ help: change this to: `&str`

src/tools/lint-docs/src/groups.rs

@@ -26,6 +26,7 @@ static GROUP_DESCRIPTIONS: &[(&str, &str)] = &[
         "Lints that detect identifiers which will be come keywords in later editions",
     ),
     ("deprecated-safe", "Lints for functions which were erroneously marked as safe in the past"),
+    ("improper-c-boundaries", "Lints for points where rust code interacts with non-rust code"),
 ];
 
 type LintGroups = BTreeMap<String, BTreeSet<String>>;

src/tools/miri/tests/fail/function_calls/exported_symbol_wrong_type.rs

@@ -1,4 +1,5 @@
 #[no_mangle]
+#[allow(improper_c_var_definitions)]
 static FOO: () = ();
 
 fn main() {

tests/ui/lint/improper_ctypes/lint-pattern-types.rs

@@ -1,3 +1,9 @@
+//@ revisions: size64 size32
+//@[size64] only-64bit
+//@[size32] only-32bit
+// (this is needed because stderr writes out usize::MAX-1)
+
+
 #![feature(pattern_types, rustc_attrs)]
 #![feature(pattern_type_macro)]
 #![feature(pattern_type_range_trait,const_trait_impl)]

tests/ui/lint/improper_ctypes/lint-pattern-types.size32.stderr

@@ -0,0 +1,152 @@
+error: `extern` fn uses type `Option<(u32) is 0..>`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:27:9
+   |
+LL |     ao: Option<pattern_type!(u32 is 0..)>,
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = help: consider adding a `#[repr(C)]`, `#[repr(transparent)]`, or integer `#[repr(...)]` attribute to this enum
+   = note: enum has no representation hint
+note: the lint level is defined here
+  --> $DIR/lint-pattern-types.rs:10:9
+   |
+LL | #![deny(improper_c_fn_definitions)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: `extern` fn uses type `(u32) is 1..`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:28:8
+   |
+LL |     b: pattern_type!(u32 is 1..),
+   |        ^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = help: consider using the base type instead, or wrapping `(u32) is 1..` in an `Option<_>`
+   = note: integer-pattern types with one disallowed value and no `Option` wrapping cannot have their value be provided by non-rust code
+
+error: `extern` fn uses type `(u32) is 2..`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:30:8
+   |
+LL |     c: pattern_type!(u32 is 2..),
+   |        ^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = help: consider using the base type instead
+   = note: integer-pattern types with more than one disallowed value cannot have their value be provided by non-rust code
+
+error: `extern` fn uses type `(u32) is 2..`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:31:9
+   |
+LL |     co: Option<pattern_type!(u32 is 2..)>,
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = help: consider using the base type instead
+   = note: integer-pattern types with more than one disallowed value cannot have their value be provided by non-rust code
+
+error: `extern` fn uses type `i128`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:36:9
+   |
+LL |     e3: Option<pattern_type!(i128 is ..0x7fffffff_ffffffff_ffffffff_ffffffff)>,
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = note: 128-bit integers don't currently have a known stable ABI
+
+error: `extern` fn uses type `u128`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:38:9
+   |
+LL |     e4: Option<pattern_type!(u128 is ..0xffffffff_ffffffff_ffffffff_ffffffff)>,
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = note: 128-bit integers don't currently have a known stable ABI
+
+error: `extern` fn uses type `i128`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:42:9
+   |
+LL |     f3: Option<pattern_type!(i128 is -0x7fffffff_ffffffff_ffffffff_ffffffff..)>,
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = note: 128-bit integers don't currently have a known stable ABI
+
+error: `extern` fn uses type `u128`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:44:9
+   |
+LL |     f4: Option<pattern_type!(u128 is 1..)>,
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = note: 128-bit integers don't currently have a known stable ABI
+
+error: `extern` fn uses type `i128`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:52:10
+   |
+LL |     g31: Option<pattern_type!(i128 is ..-2 | -1..)>,
+   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = note: 128-bit integers don't currently have a known stable ABI
+
+error: `extern` fn uses type `i128`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:54:10
+   |
+LL |     g32: Option<pattern_type!(i128 is ..-1 | 0..)>,
+   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = note: 128-bit integers don't currently have a known stable ABI
+
+error: `extern` fn uses type `i128`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:56:10
+   |
+LL |     g33: Option<pattern_type!(i128 is ..0 | 1..)>,
+   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = note: 128-bit integers don't currently have a known stable ABI
+
+error: `extern` fn uses type `i128`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:58:10
+   |
+LL |     g34: Option<pattern_type!(i128 is ..1 | 2..)>,
+   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = note: 128-bit integers don't currently have a known stable ABI
+
+error: `extern` fn uses type `(usize) is 1..`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:64:9
+   |
+LL |     h1: pattern_type!(usize is 1..),
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = help: consider using the base type instead, or wrapping `(usize) is 1..` in an `Option<_>`
+   = note: integer-pattern types with one disallowed value and no `Option` wrapping cannot have their value be provided by non-rust code
+
+error: `extern` fn uses type `(usize) is 0..=4294967293`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:65:9
+   |
+LL |     h2: pattern_type!(usize is ..USZM1),
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = help: consider using the base type instead
+   = note: integer-pattern types with more than one disallowed value cannot have their value be provided by non-rust code
+
+error: `extern` fn uses type `(isize) is -2147483647..`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:67:9
+   |
+LL |     h4: pattern_type!(isize is ISZP1..),
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = help: consider using the base type instead, or wrapping `(isize) is -2147483647..` in an `Option<_>`
+   = note: integer-pattern types with one disallowed value and no `Option` wrapping cannot have their value be provided by non-rust code
+
+error: `extern` fn uses type `char`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:69:8
+   |
+LL |     h: pattern_type!(char is '\0'..),
+   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = help: consider using `u32` or `libc::wchar_t` instead
+   = note: the `char` type has no C equivalent
+
+error: `extern` fn uses type `(char) is '\0'..`, which is not FFI-safe
+  --> $DIR/lint-pattern-types.rs:69:8
+   |
+LL |     h: pattern_type!(char is '\0'..),
+   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = help: consider using the base type instead
+   = note: integer-pattern types with more than one disallowed value cannot have their value be provided by non-rust code
+
+error: aborting due to 17 previous errors
+