Skip to content

Commit eb66c6c

Browse files
committed
Generated new .stderr files
1 parent 278bff5 commit eb66c6c

File tree

4 files changed

+24
-34
lines changed

4 files changed

+24
-34
lines changed

compiler/rustc_hir_typeck/src/expr.rs

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3278,7 +3278,6 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
32783278
}
32793279

32803280
fn suggest_first_deref_field(&self, err: &mut Diag<'_>, base: &hir::Expr<'_>, field: Ident) {
3281-
<<<<<<< HEAD
32823281
err.span_label(field.span, "unknown field");
32833282
let val = if let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span)
32843283
&& base.len() < 20
@@ -3294,26 +3293,6 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
32943293
(base.span.to(field.span.shrink_to_lo()), format!("{val}).")),
32953294
],
32963295
Applicability::MaybeIncorrect,
3297-
=======
3298-
let full_span = base.span.to(field.span);
3299-
3300-
let base_snippet = self
3301-
.tcx
3302-
.sess
3303-
.source_map()
3304-
.span_to_snippet(base.span)
3305-
.unwrap_or_else(|_| "ptr".to_string());
3306-
3307-
let replacement = format!("(*{}).{}", base_snippet, field.name);
3308-
3309-
err.span_label(full_span, "unknown field access via raw pointer");
3310-
3311-
err.span_suggestion_verbose(
3312-
full_span,
3313-
"`->` is not valid in Rust; use `.` on a dereferenced raw pointer instead",
3314-
replacement,
3315-
Applicability::MachineApplicable,
3316-
>>>>>>> cf551dbca4b (improve diagnostic for raw pointer field access with ->)
33173296
);
33183297
}
33193298

tests/ui/issues/issue-11004.stderr

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,29 @@ error[E0609]: no field `x` on type `*mut A`
22
--> $DIR/issue-11004.rs:7:21
33
|
44
LL | let x : i32 = n.x;
5-
| ^ unknown field
5+
| --^
6+
| |
7+
| unknown field access via raw pointer
68
|
7-
help: `n` is a raw pointer; try dereferencing it
9+
help: use `.` on a dereferenced raw pointer instead
10+
|
11+
LL - let x : i32 = n.x;
12+
LL + let x : i32 = (*n).x;
813
|
9-
LL | let x : i32 = (*n).x;
10-
| ++ +
1114

1215
error[E0609]: no field `y` on type `*mut A`
1316
--> $DIR/issue-11004.rs:8:21
1417
|
1518
LL | let y : f64 = n.y;
16-
| ^ unknown field
19+
| --^
20+
| |
21+
| unknown field access via raw pointer
22+
|
23+
help: use `.` on a dereferenced raw pointer instead
1724
|
18-
help: `n` is a raw pointer; try dereferencing it
25+
LL - let y : f64 = n.y;
26+
LL + let y : f64 = (*n).y;
1927
|
20-
LL | let y : f64 = (*n).y;
21-
| ++ +
2228

2329
error: aborting due to 2 previous errors
2430

tests/ui/suggestions/parenthesized-deref-suggestion.stderr

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ error[E0609]: no field `opts` on type `*const Session`
22
--> $DIR/parenthesized-deref-suggestion.rs:7:30
33
|
44
LL | (sess as *const Session).opts;
5-
| ^^^^ unknown field
5+
| -------------------------^^^^
6+
| |
7+
| unknown field access via raw pointer
68
|
79
help: `the value` is a raw pointer; try dereferencing it
810
|

tests/ui/unsafe/unsafe-fn-autoderef.stderr

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,15 @@ error[E0609]: no field `f` on type `*const Rec`
22
--> $DIR/unsafe-fn-autoderef.rs:19:14
33
|
44
LL | return p.f;
5-
| ^ unknown field
5+
| --^
6+
| |
7+
| unknown field access via raw pointer
68
|
7-
help: `p` is a raw pointer; try dereferencing it
9+
help: use `.` on a dereferenced raw pointer instead
10+
|
11+
LL - return p.f;
12+
LL + return (*p).f;
813
|
9-
LL | return (*p).f;
10-
| ++ +
1114

1215
error: aborting due to 1 previous error
1316

0 commit comments

Comments
 (0)