Skip to content

Commit e4c566c

Browse files
committed
edit E0453 long explanation for style, clarity, and citizenship
It turns out that the subsequent lines of the error message comment should be aligned like this. The "turns the corresponding compiler warning" language may not be strictly the most accurate—a lint check isn't the same as a compiler warning; it emits a compiler warning if it's set to the `warn` level— but it may be worth glossing over such distinctions in favor of simple, familar phrasings for the sake of pedagogy; thanks to Guillaume Gomez for the wording suggestion. Let's also fix up the introductory clauses of the sentences about how to fix the error to put a little more emphasis on the fact that the `forbid` setting was probably there for a reason.
1 parent c17f1a6 commit e4c566c

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/librustc/diagnostics.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1456,17 +1456,17 @@ Example of erroneous code:
14561456
#[allow(non_snake_case)]
14571457
fn main() {
14581458
let MyNumber = 2; // error: allow(non_snake_case) overruled by outer
1459-
// forbid(non_snake_case)
1459+
// forbid(non_snake_case)
14601460
}
14611461
```
14621462
1463-
The `forbid` lint setting makes code that fails the lint check result in a
1464-
compilation-terminating error (like `deny`), but also prevents itself from
1465-
being overridden by inner attributes.
1463+
The `forbid` lint setting, like `deny`, turns the corresponding compiler
1464+
warning into a hard error. Unlike `deny`, `forbid` prevents itself from being
1465+
overridden by inner attributes.
14661466
1467-
You can change `forbid` to `deny` (or use `-D` instead of `-F` if the `forbid`
1468-
setting was given as a command-line option) to allow the inner lint check
1469-
attribute:
1467+
If you're sure you want to override the lint check, you can change `forbid` to
1468+
`deny` (or use `-D` instead of `-F` if the `forbid` setting was given as a
1469+
command-line option) to allow the inner lint check attribute:
14701470
14711471
```
14721472
#![deny(non_snake_case)]
@@ -1477,7 +1477,7 @@ fn main() {
14771477
}
14781478
```
14791479
1480-
Alternatively, edit the code to pass the lint check, and remove the overruled
1480+
Otherwise, edit the code to pass the lint check, and remove the overruled
14811481
attribute:
14821482
14831483
```

0 commit comments

Comments
 (0)