Skip to content

Commit d4ab681

Browse files
committed
Add comments
1 parent 41807a3 commit d4ab681

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/intrinsic/simd.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,7 @@ pub fn generic_simd_intrinsic<'a, 'gcc, 'tcx>(bx: &mut Builder<'a, 'gcc, 'tcx>,
220220
// NOTE: we cannot cast to an array and assign to its element here because the value might
221221
// not be an l-value. So, call a builtin to set the element.
222222
// TODO(antoyo): perhaps we could create a new vector or maybe there's a GIMPLE instruction for that?
223+
// TODO(antoyo): don't use target specific builtins here.
223224
let func_name =
224225
match in_len {
225226
2 => {
@@ -396,6 +397,10 @@ pub fn generic_simd_intrinsic<'a, 'gcc, 'tcx>(bx: &mut Builder<'a, 'gcc, 'tcx>,
396397
});
397398
}
398399
(Style::Int(_), Style::Float) => {
400+
// TODO: add support for internal functions in libgccjit to get access to IFN_VEC_CONVERT which is
401+
// doing like __builtin_convertvector?
402+
// Or maybe provide convert_vector as an API since it might not easy to get the
403+
// types of internal functions.
399404
unimplemented!();
400405
}
401406
(Style::Float, Style::Int(_)) => {

0 commit comments

Comments
 (0)