Skip to content

Commit d091ef8

Browse files
arielb1Ariel Ben-Yehuda
authored and
Ariel Ben-Yehuda
committed
begin auditing the C++ types in RustWrapper
1 parent 696691e commit d091ef8

File tree

20 files changed

+771
-602
lines changed

20 files changed

+771
-602
lines changed

src/librustc_driver/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ pub fn run_compiler_with_file_loader<'a, L>(args: &[String],
186186
let sopts = config::build_session_options(&matches);
187187

188188
if sopts.debugging_opts.debug_llvm {
189-
unsafe { llvm::LLVMSetDebug(1); }
189+
unsafe { llvm::LLVMRustSetDebug(1); }
190190
}
191191

192192
let descriptions = diagnostics_registry();

src/librustc_llvm/diagnostic.rs

Lines changed: 38 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,21 @@ pub enum OptimizationDiagnosticKind {
2323
OptimizationRemark,
2424
OptimizationMissed,
2525
OptimizationAnalysis,
26+
OptimizationAnalysisFPCommute,
27+
OptimizationAnalysisAliasing,
2628
OptimizationFailure,
29+
OptimizationRemarkOther,
2730
}
2831

2932
impl OptimizationDiagnosticKind {
3033
pub fn describe(self) -> &'static str {
3134
match self {
32-
OptimizationRemark => "remark",
35+
OptimizationRemark |
36+
OptimizationRemarkOther => "remark",
3337
OptimizationMissed => "missed",
3438
OptimizationAnalysis => "analysis",
39+
OptimizationAnalysisFPCommute => "floating-point",
40+
OptimizationAnalysisAliasing => "aliasing",
3541
OptimizationFailure => "failure",
3642
}
3743
}
@@ -58,11 +64,11 @@ impl OptimizationDiagnostic {
5864
message: ptr::null_mut(),
5965
};
6066

61-
super::LLVMUnpackOptimizationDiagnostic(di,
62-
&mut opt.pass_name,
63-
&mut opt.function,
64-
&mut opt.debug_loc,
65-
&mut opt.message);
67+
super::LLVMRustUnpackOptimizationDiagnostic(di,
68+
&mut opt.pass_name,
69+
&mut opt.function,
70+
&mut opt.debug_loc,
71+
&mut opt.message);
6672

6773
opt
6874
}
@@ -84,10 +90,10 @@ impl InlineAsmDiagnostic {
8490
instruction: ptr::null_mut(),
8591
};
8692

87-
super::LLVMUnpackInlineAsmDiagnostic(di,
88-
&mut opt.cookie,
89-
&mut opt.message,
90-
&mut opt.instruction);
93+
super::LLVMRustUnpackInlineAsmDiagnostic(di,
94+
&mut opt.cookie,
95+
&mut opt.message,
96+
&mut opt.instruction);
9197

9298
opt
9399
}
@@ -103,24 +109,39 @@ pub enum Diagnostic {
103109

104110
impl Diagnostic {
105111
pub unsafe fn unpack(di: DiagnosticInfoRef) -> Diagnostic {
106-
let kind = super::LLVMGetDiagInfoKind(di);
112+
use super::DiagnosticKind as Dk;
113+
let kind = super::LLVMRustGetDiagInfoKind(di);
107114

108115
match kind {
109-
super::DK_InlineAsm => InlineAsm(InlineAsmDiagnostic::unpack(di)),
116+
Dk::InlineAsm => InlineAsm(InlineAsmDiagnostic::unpack(di)),
110117

111-
super::DK_OptimizationRemark => {
118+
Dk::OptimizationRemark => {
112119
Optimization(OptimizationDiagnostic::unpack(OptimizationRemark, di))
113120
}
114-
115-
super::DK_OptimizationRemarkMissed => {
121+
Dk::OptimizationRemarkOther => {
122+
Optimization(OptimizationDiagnostic::unpack(OptimizationRemarkOther, di))
123+
}
124+
Dk::OptimizationRemarkMissed => {
116125
Optimization(OptimizationDiagnostic::unpack(OptimizationMissed, di))
117126
}
118127

119-
super::DK_OptimizationRemarkAnalysis => {
128+
Dk::OptimizationRemarkAnalysis => {
120129
Optimization(OptimizationDiagnostic::unpack(OptimizationAnalysis, di))
121130
}
122131

123-
super::DK_OptimizationFailure => {
132+
133+
Dk::OptimizationRemarkAnalysisFPCommute => {
134+
Optimization(OptimizationDiagnostic::unpack(
135+
OptimizationAnalysisFPCommute, di))
136+
}
137+
138+
Dk::OptimizationRemarkAnalysisAliasing => {
139+
Optimization(OptimizationDiagnostic::unpack(
140+
OptimizationAnalysisAliasing, di))
141+
}
142+
143+
144+
Dk::OptimizationFailure => {
124145
Optimization(OptimizationDiagnostic::unpack(OptimizationFailure, di))
125146
}
126147

0 commit comments

Comments
 (0)