Skip to content

Commit cb6451c

Browse files
committed
Remove a fixme
I don't think it's relevant, a warning is more appropriate. Easier to just maintain the order. Closes #4681
1 parent 4bca7fd commit cb6451c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/libextra/getopts.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1522,6 +1522,9 @@ mod tests {
15221522
optmulti("l")
15231523
];
15241524
1525+
// short and verbose should always be in the same order. if they
1526+
// aren't the test will fail (and in mysterious ways)
1527+
15251528
let verbose = ~[
15261529
groups::reqopt("b", "banana", "Desc", "VAL"),
15271530
groups::optopt("a", "apple", "Desc", "VAL"),
@@ -1533,7 +1536,6 @@ mod tests {
15331536
let sample_args = ~[~"--kiwi", ~"15", ~"--apple", ~"1", ~"k",
15341537
~"-p", ~"16", ~"l", ~"35"];
15351538
1536-
// FIXME #4681: sort options here?
15371539
assert!(getopts(sample_args, short)
15381540
== groups::getopts(sample_args, verbose));
15391541
}

0 commit comments

Comments
 (0)