Skip to content

Commit c384ee1

Browse files
committed
Don't reallocate when capacity is already equal to length
`Vec::shrink_to_fit()` may be called on vectors that are already the correct length. Calling out to `reallocate()` in this case is a bad idea because there is no guarantee that `reallocate()` won't allocate a new buffer anyway, and based on performance seen in external benchmarks, it seems likely that it is in fact reallocating a new buffer. Before: test string::tests::bench_exact_size_shrink_to_fit ... bench: 45 ns/iter (+/- 2) After: test string::tests::bench_exact_size_shrink_to_fit ... bench: 26 ns/iter (+/- 1)
1 parent a913fc6 commit c384ee1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/libcollections/vec.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ impl<T> Vec<T> {
356356
}
357357
self.cap = 0;
358358
}
359-
} else {
359+
} else if self.cap != self.len {
360360
unsafe {
361361
// Overflow check is unnecessary as the vector is already at
362362
// least this large.

0 commit comments

Comments
 (0)