Skip to content

Commit c0e767b

Browse files
committed
Correctly ignore some tests on windows
These two tests are notoriously flaky on the windows bots right now, so I'm ignoring them until I can investigate them some more. The truncate_works test has been flaky for quite some time, but it has gotten much worse recently. The test_exists test has been flaky since the recent std::run rewrite landed. Finally, the "unix pipe" test failure is a recent discovery on the try bots. I haven't seen this failing much, but better safe than sorry! cc #12516
1 parent 6720977 commit c0e767b

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

src/libstd/io/fs.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,9 +1106,8 @@ mod test {
11061106
file.fsync().unwrap();
11071107
file.datasync().unwrap();
11081108
drop(file);
1109-
})
1109+
} #[ignore(cfg(windows))])
11101110

1111-
#[ignore(cfg(windows))] // FIXME(#11638)
11121111
iotest!(fn truncate_works() {
11131112
let tmpdir = tmpdir();
11141113
let path = tmpdir.join("in.txt");
@@ -1138,7 +1137,7 @@ mod test {
11381137
assert_eq!(File::open(&path).read_to_end().unwrap(),
11391138
(bytes!("fo", 0, 0, 0, 0, "wut")).to_owned());
11401139
drop(file);
1141-
})
1140+
} #[ignore(cfg(windows))]) // FIXME(#11638)
11421141

11431142
iotest!(fn open_flavors() {
11441143
let tmpdir = tmpdir();

src/libstd/io/net/unix.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ mod tests {
192192
}, proc(_client) {
193193
// drop the client
194194
})
195-
})
195+
} #[ignore(cfg(windows))]) // FIXME(#12516)
196196

197197
iotest!(fn write_begone() {
198198
smalltest(proc(mut server) {

src/libstd/io/process.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -823,11 +823,10 @@ mod tests {
823823
assert!(!p.wait().success());
824824
})
825825

826-
#[ignore(cfg(windows))]
827826
iotest!(fn test_exists() {
828827
let mut p = sleeper();
829828
assert!(Process::kill(p.id(), 0).is_ok());
830829
p.signal_kill().unwrap();
831830
assert!(!p.wait().success());
832-
})
831+
} #[ignore(cfg(windows))]) // FIXME(#12516)
833832
}

0 commit comments

Comments
 (0)