Fix copy-path button

Author: GuillaumeGomez

src/librustdoc/html/static/css/rustdoc.css

@@ -1626,23 +1626,25 @@ a.tooltip:hover::after {
 #copy-path {
 	color: var(--copy-path-button-color);
 	background: var(--main-background-color);
-	height: 34px;
+	height: 30px;
+	width: 33px;
 	margin-left: 10px;
 	padding: 0;
 	padding-left: 2px;
 	border: 0;
-	width: 33px;
-	line-height: 0;
+	overflow: hidden;
 	font-size: 0;
+	display: inline-block;
+	vertical-align: bottom;
 }
-
-#copy-path:before {
+#copy-path.clicked {
+	font-size: 26px;
+}
+#copy-path:not(.clicked)::before {
 	filter: var(--copy-path-img-filter);
 	content: url('clipboard-24048e6d87f63d07.svg');
-	width: 19px;
-	height: 18px;
 }
-#copy-path:hover:before {
+#copy-path:not(.clicked):hover::before {
 	filter: var(--copy-path-img-hover-filter);
 }
 

src/librustdoc/html/static/js/main.js

@@ -1775,6 +1775,8 @@ href="https://doc.rust-lang.org/${channel}/rustdoc/read-documentation/search.htm
     if (!but) {
         return;
     }
+    let butTextNode = null;
+
     but.onclick = () => {
         const parent = but.parentElement;
         const path = [];
@@ -1797,31 +1799,22 @@ href="https://doc.rust-lang.org/${channel}/rustdoc/read-documentation/search.htm
         document.execCommand("copy");
         document.body.removeChild(el);
 
-        // There is always one children, but multiple childNodes.
-        but.children[0].style.display = "none";
-
-        let tmp;
-        if (but.childNodes.length < 2) {
-            tmp = document.createTextNode("✓");
-            but.appendChild(tmp);
-        } else {
-            onEachLazy(but.childNodes, e => {
-                if (e.nodeType === Node.TEXT_NODE) {
-                    tmp = e;
-                    return true;
-                }
-            });
-            tmp.textContent = "✓";
+        if (butTextNode === null) {
+            butTextNode = document.createTextNode("");
+            but.insertBefore(butTextNode, but.firstChild);
         }
 
+        butTextNode.textContent = "✓";
+        but.classList.add("clicked");
+
         if (reset_button_timeout !== null) {
             window.clearTimeout(reset_button_timeout);
         }
 
         function reset_button() {
-            tmp.textContent = "";
+            butTextNode.textContent = "";
             reset_button_timeout = null;
-            but.children[0].style.display = "";
+            but.classList.remove("clicked");
         }
 
         reset_button_timeout = window.setTimeout(reset_button, 1000);