Skip to content

Commit a2cba71

Browse files
committed
Remove an out-of-date FIXME comment.
This comment made sense when this crate was called `rustc_typeck`, but makes less sense now that it's called `rustc_hir_analysis`. Especially given that `check_drop_impl` is only called within the crate.
1 parent 4e14fe9 commit a2cba71

File tree

1 file changed

+4
-5
lines changed
  • compiler/rustc_hir_analysis/src/check

1 file changed

+4
-5
lines changed

compiler/rustc_hir_analysis/src/check/dropck.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
// FIXME(@lcnr): Move this module out of `rustc_hir_analysis`.
2-
//
3-
// We don't do any drop checking during hir typeck.
4-
51
use rustc_data_structures::fx::FxHashSet;
62
use rustc_errors::codes::*;
73
use rustc_errors::{ErrorGuaranteed, struct_span_code_err};
@@ -33,7 +29,10 @@ use crate::hir::def_id::{DefId, LocalDefId};
3329
/// struct/enum definition for the nominal type itself (i.e.
3430
/// cannot do `struct S<T>; impl<T:Clone> Drop for S<T> { ... }`).
3531
///
36-
pub fn check_drop_impl(tcx: TyCtxt<'_>, drop_impl_did: DefId) -> Result<(), ErrorGuaranteed> {
32+
pub(crate) fn check_drop_impl(
33+
tcx: TyCtxt<'_>,
34+
drop_impl_did: DefId,
35+
) -> Result<(), ErrorGuaranteed> {
3736
match tcx.impl_polarity(drop_impl_did) {
3837
ty::ImplPolarity::Positive => {}
3938
ty::ImplPolarity::Negative => {

0 commit comments

Comments
 (0)