only warn for private items or public references

Author: Oliver Schneider

src/librustc_lint/builtin.rs

@@ -122,14 +122,23 @@ impl LintPass for StaticCouldBeConst {
     }
 
     fn check_item(&mut self, cx: &Context, it: &ast::Item) {
-        let expr = match it.node {
-            ast::ItemStatic(_, ast::MutImmutable, ref expr) => expr,
+        let (ty, expr) = match it.node {
+            ast::ItemStatic(ref ty, ast::MutImmutable, ref expr) => (ty, expr),
             _ => return,
         };
         let const_qualif = cx.tcx.const_qualif_map.borrow()[&expr.id];
         if const_qualif.contains(check_const::ConstQualif::MUTABLE_MEM) {
             return;
         }
+        // public item?
+        if cx.exported_items.contains(&it.id) {
+            let ty = cx.tcx.ast_ty_to_ty_cache.borrow()[&ty.id];
+            match ty.sty {
+                ty::sty::ty_rptr(..) => {},
+                // don't warn for public non-refs
+                _ => return,
+            }
+        }
         cx.span_lint(STATIC_COULD_BE_CONST, it.span, "static could be replaced by a const");
     }
 }