Skip to content

Commit 8b43da1

Browse files
committed
run-make-support: remove env_var
This is incorrectly named (it's actually `env_clear`), and is itself a gigantic footgun: removing `TMPDIR` on Unix and `TMP`/`TEMP` on Windows basically wrecks anything that relies on `std::env::temp_dir` from functioning correctly. For example, this includes rustc's codegen.
1 parent 4f3a276 commit 8b43da1

File tree

1 file changed

+0
-6
lines changed
  • src/tools/run-make-support/src

1 file changed

+0
-6
lines changed

src/tools/run-make-support/src/lib.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -372,12 +372,6 @@ macro_rules! impl_common_helpers {
372372
self
373373
}
374374

375-
/// Clear all environmental variables.
376-
pub fn env_var(&mut self) -> &mut Self {
377-
self.cmd.env_clear();
378-
self
379-
}
380-
381375
/// Generic command argument provider. Prefer specific helper methods if possible.
382376
/// Note that for some executables, arguments might be platform specific. For C/C++
383377
/// compilers, arguments might be platform *and* compiler specific.

0 commit comments

Comments
 (0)