Skip to content

Commit 85de4ef

Browse files
committed
Rename amt variables to shift
1 parent 5c8741f commit 85de4ef

File tree

6 files changed

+22
-22
lines changed

6 files changed

+22
-22
lines changed

src/librustc/mir/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1910,8 +1910,8 @@ pub fn print_miri_value<W: Write>(value: Value, ty: Ty, f: &mut W) -> fmt::Resul
19101910
let ty = tcx.lift_to_global(&ty).unwrap();
19111911
tcx.layout_of(ty::ParamEnv::empty().and(ty)).unwrap().size.bits()
19121912
});
1913-
let amt = 128 - bit_width;
1914-
write!(f, "{:?}{}", ((bits as i128) << amt) >> amt, i)
1913+
let shift = 128 - bit_width;
1914+
write!(f, "{:?}{}", ((bits as i128) << shift) >> shift, i)
19151915
},
19161916
(Value::Scalar(Scalar::Bits { bits, .. }), &TyChar) =>
19171917
write!(f, "{:?}", ::std::char::from_u32(bits as u32).unwrap()),

src/librustc/ty/sty.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1827,8 +1827,8 @@ impl<'tcx> Const<'tcx> {
18271827
let size = tcx.layout_of(ty).unwrap_or_else(|e| {
18281828
panic!("could not compute layout for {:?}: {:?}", ty, e)
18291829
}).size;
1830-
let amt = 128 - size.bits();
1831-
let truncated = (bits << amt) >> amt;
1830+
let shift = 128 - size.bits();
1831+
let truncated = (bits << shift) >> shift;
18321832
assert_eq!(truncated, bits, "from_bits called with untruncated value");
18331833
Self::from_scalar(tcx, Scalar::Bits { bits, defined: size.bits() as u8 }, ty.value)
18341834
}

src/librustc/ty/util.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,14 @@ impl<'tcx> Discr<'tcx> {
6868
};
6969

7070
let bit_size = int.size().bits();
71-
let amt = 128 - bit_size;
71+
let shift = 128 - bit_size;
7272
if signed {
7373
let sext = |u| {
7474
let i = u as i128;
75-
(i << amt) >> amt
75+
(i << shift) >> shift
7676
};
7777
let min = sext(1_u128 << (bit_size - 1));
78-
let max = i128::max_value() >> amt;
78+
let max = i128::max_value() >> shift;
7979
let val = sext(self.val);
8080
assert!(n < (i128::max_value() as u128));
8181
let n = n as i128;
@@ -87,13 +87,13 @@ impl<'tcx> Discr<'tcx> {
8787
};
8888
// zero the upper bits
8989
let val = val as u128;
90-
let val = (val << amt) >> amt;
90+
let val = (val << shift) >> shift;
9191
(Self {
9292
val: val as u128,
9393
ty: self.ty,
9494
}, oflo)
9595
} else {
96-
let max = u128::max_value() >> amt;
96+
let max = u128::max_value() >> shift;
9797
let val = self.val;
9898
let oflo = val > max - n;
9999
let val = if oflo {

src/librustc_mir/hair/cx/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,9 @@ impl<'a, 'gcx, 'tcx> Cx<'a, 'gcx, 'tcx> {
158158
let trunc = |n| {
159159
let param_ty = self.param_env.and(self.tcx.lift_to_global(&ty).unwrap());
160160
let bit_width = self.tcx.layout_of(param_ty).unwrap().size.bits();
161-
trace!("trunc {} with size {} and amt {}", n, bit_width, 128 - bit_width);
162-
let amt = 128 - bit_width;
163-
let result = (n << amt) >> amt;
161+
trace!("trunc {} with size {} and shift {}", n, bit_width, 128 - bit_width);
162+
let shift = 128 - bit_width;
163+
let result = (n << shift) >> shift;
164164
trace!("trunc result: {}", result);
165165
ConstValue::Scalar(Scalar::Bits {
166166
bits: result,

src/librustc_mir/interpret/eval_context.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -930,17 +930,17 @@ impl<'a, 'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> EvalContext<'a, 'mir, 'tcx, M
930930
let i = raw_discr.to_bits(discr.size)? as i128;
931931
// going from layout tag type to typeck discriminant type
932932
// requires first sign extending with the layout discriminant
933-
let amt = 128 - discr.size.bits();
934-
let sexted = (i << amt) >> amt;
933+
let shift = 128 - discr.size.bits();
934+
let sexted = (i << shift) >> shift;
935935
// and then zeroing with the typeck discriminant type
936936
let discr_ty = ty
937937
.ty_adt_def().expect("tagged layout corresponds to adt")
938938
.repr
939939
.discr_type();
940940
let discr_ty = layout::Integer::from_attr(self.tcx.tcx, discr_ty);
941-
let amt = 128 - discr_ty.size().bits();
941+
let shift = 128 - discr_ty.size().bits();
942942
let truncatee = sexted as u128;
943-
(truncatee << amt) >> amt
943+
(truncatee << shift) >> shift
944944
} else {
945945
raw_discr.to_bits(discr.size)?
946946
}
@@ -1005,8 +1005,8 @@ impl<'a, 'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> EvalContext<'a, 'mir, 'tcx, M
10051005
// their computation, but the in-memory tag is the smallest possible
10061006
// representation
10071007
let size = tag.value.size(self.tcx.tcx).bits();
1008-
let amt = 128 - size;
1009-
let discr_val = (discr_val << amt) >> amt;
1008+
let shift = 128 - size;
1009+
let discr_val = (discr_val << shift) >> shift;
10101010

10111011
let (discr_dest, tag) = self.place_field(dest, mir::Field::new(0), layout)?;
10121012
self.write_scalar(discr_dest, Scalar::Bits {

src/librustc_mir/interpret/mod.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,17 @@ pub fn sign_extend<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, value: u128, ty: Ty<'t
4343
let size = layout.size.bits();
4444
assert!(layout.abi.is_signed());
4545
// sign extend
46-
let amt = 128 - size;
46+
let shift = 128 - size;
4747
// shift the unsigned value to the left
4848
// and back to the right as signed (essentially fills with FF on the left)
49-
Ok((((value << amt) as i128) >> amt) as u128)
49+
Ok((((value << shift) as i128) >> shift) as u128)
5050
}
5151

5252
pub fn truncate<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, value: u128, ty: Ty<'tcx>) -> EvalResult<'tcx, u128> {
5353
let param_env = ParamEnv::empty();
5454
let layout = tcx.layout_of(param_env.and(ty)).map_err(|layout| EvalErrorKind::Layout(layout))?;
5555
let size = layout.size.bits();
56-
let amt = 128 - size;
56+
let shift = 128 - size;
5757
// truncate (shift left to drop out leftover values, shift right to fill with zeroes)
58-
Ok((value << amt) >> amt)
58+
Ok((value << shift) >> shift)
5959
}

0 commit comments

Comments
 (0)