Revert "Filtering spans"

This reverts commit d652f0ea588ecdf96d31a86fcc9aaa5f78f734a2.

Author: kper

compiler/rustc_errors/src/json.rs

@@ -319,7 +319,7 @@ impl Diagnostic {
                 message: translated_message.to_string(),
                 code: None,
                 level: "help",
-                spans: Self::filter_empty_spans_with_no_replacement(DiagnosticSpan::from_suggestion(sugg, &args, je)),
+                spans: DiagnosticSpan::from_suggestion(sugg, &args, je),
                 children: vec![],
                 rendered: None,
             }
@@ -372,12 +372,6 @@ impl Diagnostic {
         }
     }
 
-    fn filter_empty_spans_with_no_replacement(spans: Vec<DiagnosticSpan>) -> Vec<DiagnosticSpan> {
-        spans.into_iter()
-            .filter(|span| !(span.byte_start == span.byte_end && span.suggested_replacement == Some(String::new())))
-            .collect()
-    }
-
     fn from_sub_diagnostic(
         diag: &SubDiagnostic,
         args: &FluentArgs<'_>,