Skip to content

Commit 6cb0600

Browse files
committed
---
yaml --- r: 277478 b: refs/heads/try c: 33bb269 h: refs/heads/master
1 parent afc18b5 commit 6cb0600

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
refs/heads/master: 6dbb0e86aec11050480beb76eade6fb805010ba7
33
refs/heads/snap-stage3: 235d77457d80b549dad3ac36d94f235208a1eafb
4-
refs/heads/try: 3bcf818a8ff23711a2d0366d440a6bf27e16da03
4+
refs/heads/try: 33bb26998c3ef4982a4e838a626e6837f602263a
55
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
66
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
77
refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try/src/librustc_resolve/lib.rs

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1819,11 +1819,21 @@ impl<'a, 'tcx> Resolver<'a, 'tcx> {
18191819
path_depth)));
18201820

18211821
// If it's a typedef, give a note
1822-
if let Def::TyAlias(did) = path_res.base_def {
1822+
if let Def::TyAlias(..) = path_res.base_def {
18231823
err.fileline_note(trait_path.span,
18241824
"`type` aliases cannot be used for traits");
1825-
if let Some(sp) = self.ast_map.span_if_local(did) {
1826-
err.span_note(sp, "type defined here");
1825+
1826+
let definition_site = {
1827+
let segments = &trait_path.segments;
1828+
if trait_path.global {
1829+
self.resolve_crate_relative_path(trait_path.span, segments, TypeNS)
1830+
} else {
1831+
self.resolve_module_relative_path(trait_path.span, segments, TypeNS)
1832+
}.map(|binding| binding.span).unwrap_or(codemap::DUMMY_SP)
1833+
};
1834+
1835+
if definition_site != codemap::DUMMY_SP {
1836+
err.span_note(definition_site, "type defined here");
18271837
}
18281838
}
18291839
err.emit();

0 commit comments

Comments
 (0)