resolve where clauses in types in impls

Author: nikomatsakis

src/librustc_resolve/lib.rs

@@ -2525,15 +2525,15 @@ impl<'a, 'crateloader: 'a> Resolver<'a, 'crateloader> {
 
                                             visit::walk_impl_item(this, impl_item);
                                         }
-                                        ImplItemKind::Type(ref ty) => {
+                                        ImplItemKind::Type(..) => {
                                             // If this is a trait impl, ensure the type
                                             // exists in trait
                                             this.check_trait_item(impl_item.ident,
                                                                   TypeNS,
                                                                   impl_item.span,
                                                 |n, s| TypeNotMemberOfTrait(n, s));
 
-                                            this.visit_ty(ty);
+                                            visit::walk_impl_item(this, impl_item);
                                         }
                                         ImplItemKind::Existential(ref bounds) => {
                                             // If this is a trait impl, ensure the type

src/librustc_typeck/astconv.rs

@@ -30,7 +30,7 @@ use std::slice;
 use require_c_abi_if_variadic;
 use util::common::ErrorReported;
 use util::nodemap::{FxHashSet, FxHashMap};
-use errors::{FatalError, DiagnosticId};
+use errors::DiagnosticId;
 use lint;
 
 use std::iter;
@@ -693,9 +693,6 @@ impl<'o, 'gcx: 'tcx, 'tcx> dyn AstConv<'gcx, 'tcx>+'o {
         match path.def {
             Def::Trait(trait_def_id) => trait_def_id,
             Def::TraitAlias(alias_def_id) => alias_def_id,
-            Def::Err => {
-                FatalError.raise();
-            }
             _ => unreachable!(),
         }
     }

src/test/ui/rfc1598-generic-associated-types/issue-47206.rs

@@ -0,0 +1,27 @@
+// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// Regression test for #47206: ensure that impls which have where
+// clauses don't silently fail.
+//
+// compile-pass
+
+#![feature(generic_associated_types)]
+//~^ WARNING the feature `generic_associated_types` is incomplete
+
+trait Foo {
+    type Out;
+}
+
+impl<T> Foo for Box<T> {
+    type Out where T: Clone = T;
+}
+
+fn main() {}