Skip to content

Commit 69b2fce

Browse files
committed
Auto merge of #29858 - fhahn:abort-if-path-has-spaces, r=brson
The Rust build scripts do work if the source directory contains spaces. I tried to make it work with spaces. I managed to get the Rust's and LLVM's configure scripts to work with spaces in the path, but I could not figure out how to get the Rust makefiles working. So for now, this PR updates Rust's `configure` to abort if the source path contains spaces. I also added a note about spaces in the source path to the README. I think this should close #18477 for now.
2 parents eb1d018 + 9612c9a commit 69b2fce

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

configure

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -541,6 +541,16 @@ CFG_BUILD_DIR="$(pwd)/"
541541
CFG_SELF="$0"
542542
CFG_CONFIGURE_ARGS="$@"
543543

544+
545+
case "${CFG_SRC_DIR}" in
546+
*\ * )
547+
err "The path to the rust source directory contains spaces, which is not supported"
548+
;;
549+
*)
550+
;;
551+
esac
552+
553+
544554
OPTIONS=""
545555
HELP=0
546556
if [ "$1" = "--help" ]

0 commit comments

Comments
 (0)