---

yaml
---
r: 276939
b: refs/heads/try
c: 50a40e1
h: refs/heads/master
i:
  276937: 6709f5f
  276935: aba4cf2

Author: nikomatsakis

[refs]

@@ -1,7 +1,7 @@
 ---
 refs/heads/master: 6dbb0e86aec11050480beb76eade6fb805010ba7
 refs/heads/snap-stage3: 235d77457d80b549dad3ac36d94f235208a1eafb
-refs/heads/try: a2e0cbc6fc64db7672d8b0d5140dea964c1abf23
+refs/heads/try: 50a40e1c37761acc404d4b95e0448d7a01b6e38b
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
 refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try/src/librustc_incremental/calculate_svh.rs

@@ -44,8 +44,10 @@ impl<'tcx> SvhCalculate for ty::TyCtxt<'tcx> {
         let mut state = SipHasher::new();
         debug!("state: {:?}", state);
 
+        // FIXME(#32753) -- at (*) we `to_le` for endianness, but is
+        // this enough, and does it matter anyway?
         "crate_disambiguator".hash(&mut state);
-        crate_disambiguator.as_str().len().hash(&mut state);
+        crate_disambiguator.as_str().len().to_le().hash(&mut state); // (*)
         crate_disambiguator.as_str().hash(&mut state);
 
         debug!("crate_disambiguator: {:?}", crate_disambiguator.as_str());

branches/try/src/librustc_incremental/persist/load.rs

@@ -151,6 +151,7 @@ fn initial_dirty_nodes<'tcx>(tcx: &ty::TyCtxt<'tcx>,
     for hashed_item in hashed_items {
         match retraced.def_id(hashed_item.index) {
             Some(def_id) => {
+                // FIXME(#32753) -- should we use a distinct hash here
                 let current_hash = tcx.calculate_item_hash(def_id);
                 debug!("initial_dirty_nodes: hash of {:?} is {:?}, was {:?}",
                        def_id, current_hash, hashed_item.hash);

branches/try/src/librustc_incremental/persist/save.rs

@@ -93,6 +93,7 @@ pub fn encode_dep_graph<'tcx>(tcx: &ty::TyCtxt<'tcx>,
                      assert!(def_id.is_local());
                      builder.add(def_id)
                             .map(|index| {
+                                // FIXME(#32753) -- should we use a distinct hash here
                                 let hash = tcx.calculate_item_hash(def_id);
                                 SerializedHash { index: index, hash: hash }
                             })