Skip to content

Commit 5238b52

Browse files
committed
Reword un-closed delimiter label
1 parent 1c2e17f commit 5238b52

10 files changed

+25
-26
lines changed

src/libsyntax/parse/lexer/tokentrees.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ impl<'a> StringReader<'a> {
4949
let msg = "this file contains an un-closed delimiter";
5050
let mut err = self.sess.span_diagnostic.struct_span_err(self.span, msg);
5151
for &(_, sp) in &self.open_braces {
52-
err.span_help(sp, "did you mean to close this delimiter?");
52+
err.span_label(sp, "un-closed delimiter");
5353
}
5454

5555
Err(err)
@@ -94,7 +94,7 @@ impl<'a> StringReader<'a> {
9494
// delimiter. The previous unclosed delimiters could actually be
9595
// closed! The parser just hasn't gotten to them yet.
9696
if let Some(&(_, sp)) = self.open_braces.last() {
97-
err.span_label(sp, "unclosed delimiter");
97+
err.span_label(sp, "un-closed delimiter");
9898
};
9999
err.emit();
100100
}

src/test/ui/issue-10636-1.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010

1111
// compile-flags: -Z parse-only
1212

13-
struct Obj { //~ NOTE: unclosed delimiter
13+
struct Obj {
14+
//~^ NOTE: un-closed delimiter
1415
member: usize
1516
)
1617
//~^ ERROR incorrect close delimiter

src/test/ui/issue-10636-1.stderr

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
error: incorrect close delimiter: `)`
2-
--> $DIR/issue-10636-1.rs:15:1
2+
--> $DIR/issue-10636-1.rs:16:1
33
|
4-
LL | struct Obj { //~ NOTE: unclosed delimiter
5-
| - unclosed delimiter
6-
LL | member: usize
4+
LL | struct Obj {
5+
| - un-closed delimiter
6+
...
77
LL | )
88
| ^ incorrect close delimiter
99

src/test/ui/parser-recovery-1.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,12 @@
1414

1515
trait Foo {
1616
fn bar() {
17-
let x = foo(); //~ ERROR cannot find function `foo` in this scope
18-
17+
let x = foo();
18+
//~^ ERROR cannot find function `foo` in this scope
1919
}
2020

2121
fn main() {
22-
let x = y.; //~ ERROR unexpected token
23-
//~^ ERROR cannot find value `y` in this scope
22+
let x = y.;
23+
//~^ ERROR unexpected token
24+
//~| ERROR cannot find value `y` in this scope
2425
} //~ ERROR this file contains an un-closed delimiter

src/test/ui/parser-recovery-1.stderr

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,28 @@
11
error: this file contains an un-closed delimiter
2-
--> $DIR/parser-recovery-1.rs:24:55
2+
--> $DIR/parser-recovery-1.rs:25:55
33
|
4+
LL | trait Foo {
5+
| - un-closed delimiter
6+
...
47
LL | } //~ ERROR this file contains an un-closed delimiter
58
| ^
6-
|
7-
help: did you mean to close this delimiter?
8-
--> $DIR/parser-recovery-1.rs:15:11
9-
|
10-
LL | trait Foo {
11-
| ^
129

1310
error: unexpected token: `;`
1411
--> $DIR/parser-recovery-1.rs:22:15
1512
|
16-
LL | let x = y.; //~ ERROR unexpected token
13+
LL | let x = y.;
1714
| ^
1815

1916
error[E0425]: cannot find function `foo` in this scope
2017
--> $DIR/parser-recovery-1.rs:17:17
2118
|
22-
LL | let x = foo(); //~ ERROR cannot find function `foo` in this scope
19+
LL | let x = foo();
2320
| ^^^ not found in this scope
2421

2522
error[E0425]: cannot find value `y` in this scope
2623
--> $DIR/parser-recovery-1.rs:22:13
2724
|
28-
LL | let x = y.; //~ ERROR unexpected token
25+
LL | let x = y.;
2926
| ^ not found in this scope
3027

3128
error[E0601]: `main` function not found in crate `parser_recovery_1`

src/test/ui/parser-recovery-2.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error: incorrect close delimiter: `)`
22
--> $DIR/parser-recovery-2.rs:18:5
33
|
44
LL | fn bar() {
5-
| - unclosed delimiter
5+
| - un-closed delimiter
66
LL | let x = foo(); //~ ERROR cannot find function `foo` in this scope
77
LL | ) //~ ERROR incorrect close delimiter: `)`
88
| ^ incorrect close delimiter

src/test/ui/resolve/token-error-correct-2.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error: incorrect close delimiter: `)`
22
--> $DIR/token-error-correct-2.rs:16:5
33
|
44
LL | if foo {
5-
| - unclosed delimiter
5+
| - un-closed delimiter
66
LL | //~^ ERROR: cannot find value `foo`
77
LL | ) //~ ERROR: incorrect close delimiter: `)`
88
| ^ incorrect close delimiter

src/test/ui/resolve/token-error-correct-3.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error: incorrect close delimiter: `}`
22
--> $DIR/token-error-correct-3.rs:30:9
33
|
44
LL | callback(path.as_ref(); //~ ERROR expected one of
5-
| - unclosed delimiter
5+
| - un-closed delimiter
66
...
77
LL | } else { //~ ERROR: incorrect close delimiter: `}`
88
| ^ incorrect close delimiter

src/test/ui/resolve/token-error-correct.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error: incorrect close delimiter: `}`
22
--> $DIR/token-error-correct.rs:16:1
33
|
44
LL | foo(bar(;
5-
| - unclosed delimiter
5+
| - un-closed delimiter
66
LL | //~^ ERROR: expected expression, found `;`
77
LL | }
88
| ^ incorrect close delimiter

src/test/ui/token/issue-10636-2.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ error: incorrect close delimiter: `}`
22
--> $DIR/issue-10636-2.rs:18:1
33
|
44
LL | option.map(|some| 42;
5-
| - unclosed delimiter
5+
| - un-closed delimiter
66
...
77
LL | } //~ ERROR: incorrect close delimiter
88
| ^ incorrect close delimiter

0 commit comments

Comments
 (0)