Skip to content

Commit 471dee2

Browse files
authored
Rollup merge of #141967 - jieyouxu:bootstrap-backports, r=Kobzol
Configure bootstrap backport nominations through triagebot Following the discussion in [#t-infra/bootstrap > ✔ Have triagebot create backport nomination threads?](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/.E2.9C.94.20Have.20triagebot.20create.20backport.20nomination.20threads.3F/with/521876500) where we noticed that bootstrap backport nominations were difficult to track, since: - We don't really have a dedicated person / group of people checking for bootstrap backport nominations. - We don't really have an establish way of handling bootstrap backports. This PR configures triagebot to open backport nominations threads (indicated for bootstrap team if a given PR has the suitable team label, https://github.com/rust-lang/rust/labels/T-bootstrap) in [#t-infra/bootstrap/backports](https://rust-lang.zulipchat.com/#narrow/channel/507486-t-infra.2Fbootstrap.2Fbackports). The current configuration is such that **the whole bootstrap team will be pinged for bootstrap backport nominations**[^diverges]. ### Steps - [x] ~~Ping members who opt-in subscribe to backport channel, or ping the whole bootstrap team?~~ - Poll: [#t-infra/bootstrap > Have triagebot create backport nomination threads? @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Have.20triagebot.20create.20backport.20nomination.20threads.3F/near/522141337) - Votes (as of 2025-06-10): 3 votes "no preference", 1 vote "in favor". - [x] ~~(Best for follow-up) Maybe also document bootstrap team's backport process / decision process in Forge? It's a bit different from [compiler team's backport process](https://forge.rust-lang.org/compiler/backports.html) because we don't have weekly bootstrap triage meetings and thus don't have sync backport decisions.~~ - Tracked as follow-up in Forge: rust-lang/rust-forge#889. --- r? Kobzol [^diverges]: Note that this configuration is similar to the types team backport nominations, but diverges from the compiler team.
2 parents 0a39445 + 6f48758 commit 471dee2

File tree

1 file changed

+35
-0
lines changed

1 file changed

+35
-0
lines changed

triagebot.toml

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -729,6 +729,41 @@ don't know
729729
]
730730
message_on_remove = "PR #{number}'s stable-nomination has been removed."
731731

732+
[notify-zulip."beta-nominated".bootstrap]
733+
required_labels = ["T-bootstrap"]
734+
zulip_stream = 507486 # #t-infra/bootstrap/backports
735+
topic = "#{number}: beta-nominated"
736+
message_on_add = [
737+
"""\
738+
@*T-bootstrap* PR #{number} "{title}" has been nominated for beta backport.
739+
""",
740+
"""\
741+
/poll Approve beta backport of #{number}?
742+
approve
743+
decline
744+
don't know
745+
""",
746+
]
747+
message_on_remove = "PR #{number}'s beta-nomination has been removed."
748+
749+
[notify-zulip."stable-nominated".bootstrap]
750+
required_labels = ["T-bootstrap"]
751+
zulip_stream = 507486 # #t-infra/bootstrap/backports
752+
topic = "#{number}: stable-nominated"
753+
message_on_add = [
754+
"""\
755+
@*T-bootstrap* PR #{number} "{title}" has been nominated for stable backport.
756+
""",
757+
"""\
758+
/poll Approve stable backport of #{number}?
759+
approve
760+
approve (but does not justify new dot release on its own)
761+
decline
762+
don't know
763+
""",
764+
]
765+
message_on_remove = "PR #{number}'s stable-nomination has been removed."
766+
732767
[notify-zulip."A-edition-2021"]
733768
required_labels = ["C-bug"]
734769
zulip_stream = 268952 # #edition

0 commit comments

Comments
 (0)