Skip to content

Commit 46cfba2

Browse files
Rollup merge of #37462 - Mark-Simulacrum:remove-obsolete-fixme, r=petrochenkov
Remove outdated fixme comment. Linked issue has been closed, but the comment was not removed. If this is still an issue, then the comment should probably be updated. r? @petrochenkov
2 parents 6627cb8 + 709a06b commit 46cfba2

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/librustc_privacy/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -859,9 +859,6 @@ impl<'a, 'tcx, 'v> Visitor<'v> for ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx>
859859
// expression/block context can't possibly contain exported things.
860860
// (Making them no-ops stops us from traversing the whole AST without
861861
// having to be super careful about our `walk_...` calls above.)
862-
// FIXME(#29524): Unfortunately this ^^^ is not true, blocks can contain
863-
// exported items (e.g. impls) and actual code in rustc itself breaks
864-
// if we don't traverse blocks in `EmbargoVisitor`
865862
fn visit_block(&mut self, _: &hir::Block) {}
866863
fn visit_expr(&mut self, _: &hir::Expr) {}
867864
}

0 commit comments

Comments
 (0)